New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .NET Core 2.0 #888

Merged
merged 8 commits into from Aug 16, 2017

Conversation

Projects
None yet
3 participants
@RSuter
Owner

RSuter commented Aug 16, 2017

No description provided.

@stumpyfr

This comment has been minimized.

Show comment
Hide comment
@stumpyfr

stumpyfr Aug 16, 2017

When the release will integrate the support of 2.0? last step to update all my CI to netcore 2.0 :)

Thanks for your work!

stumpyfr commented on 1071359 Aug 16, 2017

When the release will integrate the support of 2.0? last step to update all my CI to netcore 2.0 :)

Thanks for your work!

This comment has been minimized.

Show comment
Hide comment
@RSuter

RSuter Aug 16, 2017

Owner

At the moment I cannot build for .NET Core 2.0 (and also AppVeyor has problems with it). Can you build the solution with this commit?

Owner

RSuter replied Aug 16, 2017

At the moment I cannot build for .NET Core 2.0 (and also AppVeyor has problems with it). Can you build the solution with this commit?

This comment has been minimized.

Show comment
Hide comment
@stumpyfr

stumpyfr Aug 16, 2017

just tried and 1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.TargetFrameworkInference.targets(112,5): error : The current .NET SDK does not support targeting .NET Core 2.0. Either target .NET Core 1.1 or lower, or use a version of the .NET SDK that supports .NET Core 2.0.

no idea why, I am investigating

stumpyfr replied Aug 16, 2017

just tried and 1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.TargetFrameworkInference.targets(112,5): error : The current .NET SDK does not support targeting .NET Core 2.0. Either target .NET Core 1.1 or lower, or use a version of the .NET SDK that supports .NET Core 2.0.

no idea why, I am investigating

This comment has been minimized.

Show comment
Hide comment
@RSuter

RSuter Aug 16, 2017

Owner

Looks good - locally. But I have to integrate this in the CI (AppVeyor). Do you know how to install .NET Core 2.0 via command line (powershell) so that we can install it before building on the CI system?

Owner

RSuter replied Aug 16, 2017

Looks good - locally. But I have to integrate this in the CI (AppVeyor). Do you know how to install .NET Core 2.0 via command line (powershell) so that we can install it before building on the CI system?

This comment has been minimized.

Show comment
Hide comment

@RSuter RSuter merged commit f41686d into master Aug 16, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@RSuter RSuter deleted the netcoreapp2.0 branch Aug 16, 2017

@gozdebozkurt

This comment has been minimized.

Show comment
Hide comment
@gozdebozkurt

gozdebozkurt Aug 25, 2017

Contributor

@RSuter is there any progress on getting the build to work?

Is there any way we can help?

If you shared your appveyor.yml we could work on this in our fork (or maybe even keep in the repo, as described in your Settings section)

Contributor

gozdebozkurt commented Aug 25, 2017

@RSuter is there any progress on getting the build to work?

Is there any way we can help?

If you shared your appveyor.yml we could work on this in our fork (or maybe even keep in the repo, as described in your Settings section)

@RSuter

This comment has been minimized.

Show comment
Hide comment
@RSuter

RSuter Aug 25, 2017

Owner

It seems that the VM is missing the latest .NET Core version... I'm just looking into it.

Owner

RSuter commented Aug 25, 2017

It seems that the VM is missing the latest .NET Core version... I'm just looking into it.

@RSuter

This comment has been minimized.

Show comment
Hide comment
@RSuter

RSuter Aug 25, 2017

Owner

The appveyor.yml is

version: '{build}'
branches:
  except:
  - release
image: Visual Studio 2017 Preview
configuration: Release
platform: Any CPU
before_build:
- cmd: >-
    npm --prefix "src\NSwag.Integration.TypeScriptWeb" install "src\NSwag.Integration.TypeScriptWeb"


    nuget restore src\NSwag.sln -NoCache

    dotnet restore src\NSwag.sln --no-cache
build:
  project: src\NSwag.sln
  verbosity: minimal
after_build:
- cmd: >-
    nuget pack src/NSwag.MSBuild/NSwag.MSBuild.nuspec

    nuget pack src/NSwagStudio.Chocolatey/NSwagStudio.nuspec
test:
  categories:
    except:
    - integration
artifacts:
- path: '*.nupkg'
- path: src\NSwagStudio.Installer\bin\Release\NSwagStudio.msi
  name: NSwagStudio.msi
- path: src\NSwagStudio\bin\Release
  name: NSwag
- path: src\NSwagStudio\Properties\AssemblyInfo.cs
- path: src/NSwag**/*.nupkg
deploy:
- provider: NuGet
  server: https://www.myget.org/F/nswag-ci/api/v2/package
  api_key:
    secure: ***
  skip_symbols: true
  on:
    branch: master
Owner

RSuter commented Aug 25, 2017

The appveyor.yml is

version: '{build}'
branches:
  except:
  - release
image: Visual Studio 2017 Preview
configuration: Release
platform: Any CPU
before_build:
- cmd: >-
    npm --prefix "src\NSwag.Integration.TypeScriptWeb" install "src\NSwag.Integration.TypeScriptWeb"


    nuget restore src\NSwag.sln -NoCache

    dotnet restore src\NSwag.sln --no-cache
build:
  project: src\NSwag.sln
  verbosity: minimal
after_build:
- cmd: >-
    nuget pack src/NSwag.MSBuild/NSwag.MSBuild.nuspec

    nuget pack src/NSwagStudio.Chocolatey/NSwagStudio.nuspec
test:
  categories:
    except:
    - integration
artifacts:
- path: '*.nupkg'
- path: src\NSwagStudio.Installer\bin\Release\NSwagStudio.msi
  name: NSwagStudio.msi
- path: src\NSwagStudio\bin\Release
  name: NSwag
- path: src\NSwagStudio\Properties\AssemblyInfo.cs
- path: src/NSwag**/*.nupkg
deploy:
- provider: NuGet
  server: https://www.myget.org/F/nswag-ci/api/v2/package
  api_key:
    secure: ***
  skip_symbols: true
  on:
    branch: master
@gozdebozkurt

This comment has been minimized.

Show comment
Hide comment
@gozdebozkurt

gozdebozkurt Aug 29, 2017

Contributor

Could you give us secure variable (encrypted) for api key? I want to raise a PR to put the the appveyor.yml in source.

Contributor

gozdebozkurt commented Aug 29, 2017

Could you give us secure variable (encrypted) for api key? I want to raise a PR to put the the appveyor.yml in source.

@RSuter

This comment has been minimized.

Show comment
Hide comment
@RSuter

RSuter Aug 29, 2017

Owner

Its ok for now, ci build is working now... Please open a new issue and i can post the current appveyor.yml and secure var there...

Owner

RSuter commented Aug 29, 2017

Its ok for now, ci build is working now... Please open a new issue and i can post the current appveyor.yml and secure var there...

@RSuter

This comment has been minimized.

Show comment
Hide comment
@RSuter

RSuter Aug 29, 2017

Owner

v11.5.0

Owner

RSuter commented Aug 29, 2017

v11.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment