New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests that were failing on Windows #17

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@soren
Contributor

soren commented Aug 1, 2018

On some versions of Windows requests to localhost does not work. The
simplest way to fix this is to use 127.0.0.1 instead, which should
always work.

This is part of the CPAN Pull Request Challenge, where I got
RT::Client::REST as my July assignment.

Fix tests that were failing on Windows
On some versions of Windows requests to localhost does not work. The
simplest way to fix this is to use 127.0.0.1 instead, which should
always work.

This is part of the CPAN Pull Request Challenge, where I got
RT::Client::REST as my July assignment.

@dtikhonov dtikhonov merged commit 5f7a32a into RT-Client-REST:master Aug 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@dtikhonov

This comment has been minimized.

Show comment
Hide comment
@dtikhonov

dtikhonov Aug 1, 2018

Member

Thanks, @soren.

Member

dtikhonov commented Aug 1, 2018

Thanks, @soren.

@soren soren deleted the soren:fix-tests-failing-on-windows-due-to-localhost-dns-issue branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment