Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

建议规范代码的提交日志 #2583

Open
Zero-Free opened this issue Apr 16, 2019 · 2 comments

Comments

@Zero-Free
Copy link
Contributor

commented Apr 16, 2019

一些开发者在提交代码时,日志写的比较随意,也有一些跟描述不相干的修改,建议官方制定一些规范,提交也尽量使用英文,如:

  • 描述尽量简洁,突出重点。让人一看知道做什么。
  • 提交原子性,不要提交跟当前不相干的内容。
  • 格式必须和团队保持统一。
  • 增加前缀,如[bsp][components]

不规范的日志不仅影响代码review,也产生不严谨的错觉,如

image

@BernardXiong

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

@jhbdream 需要多多注意。

🦀 后续PR审核需要更严格才行

@XBurst

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

很有必要,如果改动量比较大时最好按步骤分成多个commit,这样便于后来者追踪改动。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.