[bsp][renesas] add EK-RA2E2 other device drivers support #10695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📌 Code Review Assignment🏷️ Tag: bsp_renesasReviewers: kurisaW Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-09-15 11:27 CST)
📝 Review Instructions
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional device drivers to the EK-RA2E2 BSP, including I2C, SPI, ADC, PWM, flash, and GPIO interrupt functionality. The changes enhance the board's peripheral driver support and update configuration files to enable these new capabilities.
Key Changes:
- Added I2C hardware driver support with compatibility layer for RA2E2 series
- Integrated SPI, PWM, and ADC driver configurations
- Enhanced flash driver with low-power flash support and callback functionality
- Updated build system with startup check and configuration adjustments
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bsp/renesas/ra2e2-ek/rtconfig.h | Updated RT_NAME_MAX and enabled event support |
| bsp/renesas/ra2e2-ek/ra_gen/pin_data.c | Removed I2C pin configurations from static setup |
| bsp/renesas/ra2e2-ek/ra/fsp/src/bsp/cmsis/Device/RENESAS/Source/startup.c | Enhanced startup sequence with multi-compiler support |
| bsp/renesas/ra2e2-ek/configuration.xml | Updated pin configuration from I2C to GPT timer modes |
| bsp/renesas/ra2e2-ek/board/ports/fal_cfg.h | Added flash abstraction layer configuration |
| bsp/renesas/ra2e2-ek/board/Kconfig | Added hardware driver menu configurations for I2C, SPI, PWM, ADC |
| bsp/renesas/ra2e2-ek/SConstruct | Integrated startup check functionality |
| bsp/renesas/ra2e2-ek/README.md | Updated board reference and RTC support status |
| bsp/renesas/ra2e2-ek/.config | Applied configuration changes for name length and event support |
| bsp/renesas/libraries/HAL_Drivers/drivers/drv_i2c.c | Added RA2E2 compatibility macros for I2C driver |
| bsp/renesas/libraries/HAL_Drivers/drivers/drv_gpio.c | Fixed missing semicolon in PIN2IRQX_TABLE macro |
| bsp/renesas/libraries/HAL_Drivers/drivers/drv_flash.c | Enhanced flash driver with LP flash support and callback |
| bsp/renesas/libraries/HAL_Drivers/drivers/config/ra2e2/pwm_config.h | Added PWM configuration header for RA2E2 |
| bsp/renesas/libraries/HAL_Drivers/drivers/config/ra2e2/adc_config.h | Added ADC configuration header for RA2E2 |
| bsp/renesas/libraries/HAL_Drivers/drivers/config/drv_config.h | Integrated RA2E2 PWM and ADC configurations |
|
|
||
| void flash_callback(flash_callback_args_t * p_args) | ||
| { | ||
|
|
There was a problem hiding this comment.
English: Empty callback function should include a comment explaining its purpose or implement basic functionality like setting completion flags. Consider adding parameter validation or basic event handling.
中文： 空的回调函数应该包含注释说明其用途，或实现基本功能如设置完成标志。建议添加参数验证或基本事件处理。
Suggested change
| /* | |
| * This callback is intentionally left empty. | |
| * No action is required on flash events in this application. | |
| * If event handling is needed, implement it here. | |
| */ |
kurisaW
requested changes
Sep 14, 2025
| #define RA_SCI_EVENT_ALL BITS(0,3) | ||
|
|
||
| #ifdef SOC_SERIES_R7FA2E2 | ||
| #define R_IIC_MASTER_Open R_IIC_B_MASTER_Open |
Member
|
另外每个外设请提交运行测试截图 |
Contributor
Author
|
kurisaW
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
增加对 EK-RA2E2 其他设备驱动的支持，包括 i2c, spi, adc, pwm, flash, gpio interrupt
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up