-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kernel][sem] remove reserved field #6103
Conversation
这个本身就是预留的区域,用来做32位对齐保留的吧 |
不可能的,郭老师可以查一下,现在信号量这个结构体32位是否对齐。也可以查一下比如线程控制块的结构体是否对齐。结构体会自动对齐到4字节的。 |
@@ -743,8 +743,7 @@ struct rt_semaphore | |||
{ | |||
struct rt_ipc_object parent; /**< inherit from ipc_object */ | |||
|
|||
rt_uint16_t value; /**< value of semaphore. */ | |||
rt_uint16_t reserved; /**< reserved field */ | |||
rt_uint16_t value; /**< value of semaphore */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不明白的,一些点上是要做对齐的
亲自动笔算一下呀 不要一想之美,实际看都不看就想当然的去认为啊:
struct rt_object
{
char name[RT_NAME_MAX]; /**< name of kernel object */
rt_uint8_t type; /**< type of kernel object */
rt_uint8_t flag; /**< flag of kernel object */
rt_list_t list; /**< list node of kernel object */
}; struct rt_ipc_object 是18+8 = 26个字节 也不是4字节对齐 struct rt_ipc_object
{
struct rt_object parent; /**< inherit from rt_object */
rt_list_t suspend_thread; /**< threads pended on this resource */
}; struct rt_semaphore是 26+2+2 = 30个字节,算上reserved30个字节 也不是4字节对齐,请问reserved在对齐啥呢? struct rt_semaphore
{
struct rt_ipc_object parent; /**< inherit from ipc_object */
rt_uint16_t value; /**< value of semaphore. */
rt_uint16_t reserved; /**< reserved field */
};
typedef struct rt_semaphore *rt_sem_t; |
拉取/合并请求描述:(PR description)
[
该成员变量无任何意义,从来没有被使用过
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up