Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kernel][sem] remove reserved field #6103

Closed
wants to merge 1 commit into from

Conversation

mysterywolf
Copy link
Member

拉取/合并请求描述:(PR description)

[
该成员变量无任何意义,从来没有被使用过
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Guozhanxin
Copy link
Member

Guozhanxin commented Jun 23, 2022

这个本身就是预留的区域,用来做32位对齐保留的吧

@mysterywolf
Copy link
Member Author

mysterywolf commented Jun 23, 2022

不可能的,郭老师可以查一下,现在信号量这个结构体32位是否对齐。也可以查一下比如线程控制块的结构体是否对齐。结构体会自动对齐到4字节的。

@@ -743,8 +743,7 @@ struct rt_semaphore
{
struct rt_ipc_object parent; /**< inherit from ipc_object */

rt_uint16_t value; /**< value of semaphore. */
rt_uint16_t reserved; /**< reserved field */
rt_uint16_t value; /**< value of semaphore */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不明白的,一些点上是要做对齐的

@mysterywolf
Copy link
Member Author

mysterywolf commented Jun 24, 2022

亲自动笔算一下呀 不要一想之美,实际看都不看就想当然的去认为啊

  1. 首先,目前我们能碰见的编译器都会帮我们自动对结构体做四字节对齐,也就是即便一个结构体里只含有一个char型变量,sizeof之后也会是4(假设CPU是32位的)。也就是目前我们的结构体实际上都不需要考虑手动对齐的问题。

  2. 好,我们假设,编译器非常傻,不能够自动处理4字节对齐的问题,傻乎乎的,结构体内,有几个成员变量,结构体的size就是多少。那么,我们看看我们凑对了嘛?以struct rt_semaphore 为例:
    rt_object 为18个字节(RT_NAME_MAX默认为8),不是4字节对齐

struct rt_object
{
    char       name[RT_NAME_MAX];                       /**< name of kernel object */
    rt_uint8_t type;                                    /**< type of kernel object */
    rt_uint8_t flag;                                    /**< flag of kernel object */
    rt_list_t  list;                                    /**< list node of kernel object */
};

struct rt_ipc_object 是18+8 = 26个字节 也不是4字节对齐

struct rt_ipc_object
{
    struct rt_object parent;                            /**< inherit from rt_object */

    rt_list_t        suspend_thread;                    /**< threads pended on this resource */
};

struct rt_semaphore是 26+2+2 = 30个字节,算上reserved30个字节 也不是4字节对齐,请问reserved在对齐啥呢?

struct rt_semaphore
{
    struct rt_ipc_object parent;                        /**< inherit from ipc_object */

    rt_uint16_t          value;                         /**< value of semaphore. */
    rt_uint16_t          reserved;                      /**< reserved field */
};
typedef struct rt_semaphore *rt_sem_t;

@mysterywolf mysterywolf added the discussion This PR/issue needs to be discussed later label Jun 25, 2022
@mysterywolf mysterywolf deleted the sem branch June 25, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This PR/issue needs to be discussed later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants