Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 warnings W605, W504 #2256

Merged
merged 4 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@horpto
Copy link
Contributor

commented Nov 2, 2018

Since recent release of flake8 (v3.6.0, 24.10.18) all PR-s have not been building due to new warnings W605 W504 (pycodestyle - dependence of flake8, version 2.4.0).

Now, by edited pep 8 you should break the line before binary operator, not after. And avoid slash with followed non-special character like 'i', '*' or others in non-raw string.

Also, here we pin flake8-rst == 0.4.3 until bug with E402 ("glue" rst) will be fixed.

@horpto horpto force-pushed the horpto:gensim-build branch from 63dc565 to da0db8c Nov 6, 2018

@horpto horpto changed the title Fix flake8 warnings W605 and build Fix flake8 warnings W605 Nov 6, 2018

@horpto horpto force-pushed the horpto:gensim-build branch from 24639a9 to e189dc6 Nov 6, 2018

@horpto horpto changed the title Fix flake8 warnings W605 Fix flake8 warnings W605, ignore W504 Nov 6, 2018

@horpto horpto force-pushed the horpto:gensim-build branch from e189dc6 to 749b691 Nov 6, 2018

@piskvorky

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

Can you fill in the PR description please?

The PR name and the codes are too cryptic: What is this PR for, why (motivation), what was the main approach for its fix(es)?

@horpto horpto force-pushed the horpto:gensim-build branch from 749b691 to f7755df Nov 11, 2018

@horpto horpto force-pushed the horpto:gensim-build branch from f7755df to 1968219 Nov 11, 2018

@horpto horpto changed the title Fix flake8 warnings W605, ignore W504 Fix flake8 warnings W605, W504 Nov 11, 2018

@menshikh-iv menshikh-iv merged commit 30528a5 into RaRe-Technologies:develop Dec 11, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@menshikh-iv

This comment has been minimized.

Copy link
Collaborator

commented Dec 11, 2018

Nice, thank you @horpto 👍

@horpto horpto deleted the horpto:gensim-build branch Jan 10, 2019

rsdel2007 added a commit to rsdel2007/gensim that referenced this pull request Jan 11, 2019

Fix flake8 warnings W605, W504 (RaRe-Technologies#2256)
* Fix flake8 warnings W605

* fix W504

* pin flake8-rst (avoid issue from 0.5.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.