New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_word2vec_format(): remove init_sims() call #555

Merged
merged 3 commits into from Dec 1, 2015

Conversation

Projects
None yet
4 participants
@svenkreiss
Copy link
Contributor

svenkreiss commented Nov 30, 2015

Change as discussed in comment thread of PR #545.
This PR solves the same issue as #545, but applies an API breaking change to solve this problem properly.

Removes parameters norm_only and init_sims.
The removal of the init_sims() call changes the default behavior.

svenkreiss added some commits Nov 30, 2015

@gojomo

This comment has been minimized.

Copy link

gojomo commented on CHANGELOG.txt in a5eccb4 Nov 30, 2015

A helpful added note would be: "call init_sims(replace=True) for old norm_only=True behavior"

@svenkreiss

This comment has been minimized.

Copy link
Contributor

svenkreiss commented Nov 30, 2015

@gojomo Good point. Done.

@piskvorky

This comment has been minimized.

Copy link
Member

piskvorky commented Dec 1, 2015

Great, thanks so much @svenkreiss !

piskvorky added a commit that referenced this pull request Dec 1, 2015

Merge pull request #555 from svenkreiss/lazy-init-sims
load_word2vec_format(): remove init_sims() call

@piskvorky piskvorky merged commit 839513f into RaRe-Technologies:develop Dec 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xingdi-eric-yuan

This comment has been minimized.

Copy link

xingdi-eric-yuan commented Feb 14, 2016

@gojomo The note helps a lot, thanks. A 30 hours debugging until I saw this PR 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment