Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unassigned template literal #32

Merged
merged 1 commit into from Jun 10, 2019

Conversation

Raathigesh
Copy link
Owner

@Raathigesh Raathigesh commented Jun 4, 2019

This will make #29 work without breaking the extension but it doesn't solve #29 completely. Looks like we don't handle nested template literals very well but we could fix that separately as an enhancement.

@Raathigesh Raathigesh requested a review from paustint June 4, 2019 11:56
@paustint
Copy link
Collaborator

paustint commented Jun 9, 2019

@Raathigesh - Can you confirm that the behavior I am seeing is what is expected? If so, then this LGTM.

Works (does not pull in properties, but also does not throw exception)

export const SearchCentering = styled.div`
  width: 100%;
  max-width: ${'1200px'};
`;

Does not work

export const SearchCentering = styled.div`
  width: 100%;
  ${mediaMin.xxl`
  margin: 0 auto;
  max-width: 1200px;
  `};
`;

@paustint paustint added this to In Review in Development Board via automation Jun 9, 2019
@Raathigesh
Copy link
Owner Author

Yes, That's something I want to look at separately. Thank you for the review.

@Raathigesh Raathigesh merged commit 7be3209 into master Jun 10, 2019
Development Board automation moved this from In Review to Done Jun 10, 2019
@Raathigesh Raathigesh deleted the handle-styled-literal-without-assignment branch June 10, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants