Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install doesn't install CMake export targets #61

Closed
rigtorp opened this issue Aug 5, 2020 · 3 comments
Closed

make install doesn't install CMake export targets #61

rigtorp opened this issue Aug 5, 2020 · 3 comments

Comments

@rigtorp
Copy link

rigtorp commented Aug 5, 2020

CMake export targets for use with find_package should be installed during installation.

See:

@kentrussell
Copy link
Contributor

kentrussell commented Aug 6, 2020

Our CMake process for this project was overhauled and this issue was addressed. Unfortunately the overhaul missed the 3.6-Beta cutoff, but will be included in the next ROCm release.

EDIT: The static-link preview has the required change. Can you try using the static_linking_preview branch and see if that addresses the issue? If so, that will be part of the next ROCm drop

@rigtorp
Copy link
Author

rigtorp commented Aug 6, 2020

I didn't try it, but it looks like that branch will install the CMake exports correctly.

@rigtorp
Copy link
Author

rigtorp commented Aug 24, 2020

Fixed in ROCm 3.7

@rigtorp rigtorp closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants