From b8dab305335d3633184f5fef3edcee3b0bf816c8 Mon Sep 17 00:00:00 2001 From: Chuneeta Date: Wed, 27 Jun 2018 13:51:24 -0700 Subject: [PATCH 1/3] Added unit tests for the pseudo-stokes functionality --- pyuvdata/tests/test_uvbeam.py | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/pyuvdata/tests/test_uvbeam.py b/pyuvdata/tests/test_uvbeam.py index b7338c4e6a..2f5ea026a5 100644 --- a/pyuvdata/tests/test_uvbeam.py +++ b/pyuvdata/tests/test_uvbeam.py @@ -178,6 +178,35 @@ def test_peak_normalize(): nt.assert_raises(NotImplementedError, power_beam.peak_normalize) +def test_stokes_matrix(): + beam = UVBeam() + nt.assert_raises(ValueError, beam._stokes_matrix, -2) + nt.assert_raises(ValueError, beam._stokes_matrix, 5) + + +def test_efield_to_pstokes(): + efield_beam = UVBeam() + efield_beam.read_cst_beam(cst_files, beam_type='efield', frequency=[150e6, 123e6], + telescope_name='TEST', feed_name='bob', + feed_version='0.1', feed_pol=['x'], + model_name='E-field pattern - Rigging height 4.9m', + model_version='1.0') + + pstokes_beam = copy.deepcopy(efield_beam) + pstokes_beam.az_za_to_healpix() + pstokes_beam.efield_to_pstokes() + + pstokes_beam = copy.deepcopy(efield_beam) + nt.assert_raises(ValueError, pstokes_beam.efield_to_pstokes) + + power_beam = UVBeam() + power_beam.read_cst_beam(cst_files, beam_type='power', frequency=[150e6, 123e6], + telescope_name='TEST', feed_name='bob', + feed_version='0.1', feed_pol=['x'], + model_name='E-field pattern - Rigging height 4.9m', + model_version='1.0') + nt.assert_raises(ValueError, power_beam.efield_to_pstokes) + def test_efield_to_power(): efield_beam = UVBeam() efield_beam.read_cst_beam(cst_files, beam_type='efield', frequency=[150e6, 123e6], @@ -1373,10 +1402,11 @@ def test_get_beam_functions(): model_name='E-field pattern - Rigging height 4.9m', model_version='1.0') - nt.assert_raises(AssertionError, power_beam._get_beam, 'I') + nt.assert_raises(AssertionError, power_beam._get_beam, 'xx') # Check only healpix accepted (HEALPix checks are in test_healpix) # change data_normalization to peak for rest of checks power_beam.peak_normalize() nt.assert_raises(ValueError, power_beam.get_beam_area) nt.assert_raises(ValueError, power_beam.get_beam_sq_area) + nt.assert_raises(AssertionError, power_beam._get_beam, 'pI') From 0ae5d16cce6ed2cfe0283daed5b5e343dd800848 Mon Sep 17 00:00:00 2001 From: Chuneeta Date: Wed, 27 Jun 2018 14:36:30 -0700 Subject: [PATCH 2/3] fixed blank lines --- pyuvdata/tests/test_uvbeam.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pyuvdata/tests/test_uvbeam.py b/pyuvdata/tests/test_uvbeam.py index 2f5ea026a5..d45d3419db 100644 --- a/pyuvdata/tests/test_uvbeam.py +++ b/pyuvdata/tests/test_uvbeam.py @@ -207,6 +207,7 @@ def test_efield_to_pstokes(): model_version='1.0') nt.assert_raises(ValueError, power_beam.efield_to_pstokes) + def test_efield_to_power(): efield_beam = UVBeam() efield_beam.read_cst_beam(cst_files, beam_type='efield', frequency=[150e6, 123e6], From bb17f10424044c8c9d41c0f9f4ece4632fbe28e1 Mon Sep 17 00:00:00 2001 From: Chuneeta Date: Wed, 27 Jun 2018 16:57:18 -0700 Subject: [PATCH 3/3] more unit tests --- pyuvdata/tests/test_uvbeam.py | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/pyuvdata/tests/test_uvbeam.py b/pyuvdata/tests/test_uvbeam.py index d45d3419db..2af5b93f53 100644 --- a/pyuvdata/tests/test_uvbeam.py +++ b/pyuvdata/tests/test_uvbeam.py @@ -196,9 +196,15 @@ def test_efield_to_pstokes(): pstokes_beam.az_za_to_healpix() pstokes_beam.efield_to_pstokes() + pstokes_beam = copy.deepcopy(efield_beam) + pstokes_beam.az_za_to_healpix() + beam_return = pstokes_beam.efield_to_pstokes(inplace=False) + pstokes_beam = copy.deepcopy(efield_beam) nt.assert_raises(ValueError, pstokes_beam.efield_to_pstokes) + pstokes_beam = copy.deepcopy(efield_beam) + power_beam = UVBeam() power_beam.read_cst_beam(cst_files, beam_type='power', frequency=[150e6, 123e6], telescope_name='TEST', feed_name='bob', @@ -207,6 +213,8 @@ def test_efield_to_pstokes(): model_version='1.0') nt.assert_raises(ValueError, power_beam.efield_to_pstokes) + nt.assert_raises(ValueError, power_beam.efield_to_pstokes) + def test_efield_to_power(): efield_beam = UVBeam() @@ -1410,4 +1418,14 @@ def test_get_beam_functions(): power_beam.peak_normalize() nt.assert_raises(ValueError, power_beam.get_beam_area) nt.assert_raises(ValueError, power_beam.get_beam_sq_area) - nt.assert_raises(AssertionError, power_beam._get_beam, 'pI') + + power_beam = UVBeam() + power_beam.read_cst_beam(cst_files[0], beam_type='power', frequency=150e6, + telescope_name='TEST', feed_name='bob', + feed_version='0.1', + model_name='E-field pattern - Rigging height 4.9m', + model_version='1.0') + power_beam.az_za_to_healpix() + power_beam.peak_normalize() + power_beam._get_beam('xx') + nt.assert_raises(ValueError, power_beam._get_beam, 4)