ENH: check if feature class name is valid #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostJM
requested changes
Mar 6, 2017
radiomics/featureextractor.py
Outdated
| @@ -284,6 +284,9 @@ def enableFeatureClassByName(self, featureClass, enabled=True): | |||
| """ | |||
| Enable or disable all features in given class. | |||
| """ | |||
| if not featureClass in self.getFeatureClassNames(): | |||
There was a problem hiding this comment.
@fedorov, flake 8 fails due to this line: if you compare with "not" and "in", flake 8 requires you to put these together, i.e. if featureClass not in self.getFeatureClassNames():
There was a problem hiding this comment.
Thanks! I admit I forgot to follow up and check the tests after submitting the PR.
fedorov
force-pushed
the
add-feature-class-check
branch
from
ea7be51
to
0db5834
Compare
|
@JoostJM the checks are now passing. |
JoostJM
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.