Skip to content

Conversation

@StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Sep 28, 2025

  • fixed legacy unity installer
  • change return type of UnityHub.GetEditor from string to UnityEditor

- fixed legacy unity installer
Copilot AI review requested due to automatic review settings September 28, 2025 02:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with the legacy Unity installer by updating PowerShell command execution methods and bumps the package version to 1.0.5.

  • Simplified PowerShell command execution by removing nested shell wrapping
  • Fixed Unity installer execution to use PowerShell Start-Process for better process management
  • Added logging for Unity installation process

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/utilities.ts Simplified PowerShell command execution for killing child processes
src/unity-hub.ts Fixed Unity installer execution and added installation logging
package.json Version bump to 1.0.5

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@StephenHodgson StephenHodgson merged commit bd4e782 into main Sep 28, 2025
3 checks passed
@StephenHodgson StephenHodgson deleted the fix/legacy-unity-installer branch September 28, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant