Skip to content

Conversation

@StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Jul 13, 2025

  • add support for modules: None input
  • reduced default installed modules to only il2cpp per platform

- add support for `modules: None` input
Copilot AI review requested due to automatic review settings July 13, 2025 15:02

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot July 13, 2025 15:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Unity Setup action to v1.1.1 and adds explicit support for passing modules: None. It unifies and exposes the install-path setter, adjusts module input parsing, and refines cleanup logic.

  • Added SetInstallPath and removed the duplicate lowercase setInstallPath
  • Updated ValidateInputs to special-case "None" modules and skip defaults when requested
  • Changed getDefaultModules defaults to only include il2cpp per platform
  • Adjusted removePath to accept undefined and only delete if the path exists

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/unity-hub.ts Added SetInstallPath, removed duplicate setter, updated removePath
src/inputs.ts Enhanced module parsing to handle "None", updated default modules
src/index.ts Guarded installPath check and renamed to SetInstallPath
package.json Bumped version from 1.1.0 to 1.1.1
README.md Fixed unity-version key naming in examples
.github/workflows/validate.yml Updated matrix key names and added cases for modules: None
Comments suppressed due to low confidence (2)

src/inputs.ts:16

  • The || [] is redundant because getArrayInput always returns an array. You can remove the fallback to simplify the code.
    const modulesInput = getArrayInput('modules') || [];

src/inputs.ts:140

  • Previously the default modules included android and ios as well. Dropping them changes the out-of-the-box behavior—verify if this was intentional or restore the prior defaults.
            return ['linux-il2cpp'];

@StephenHodgson StephenHodgson merged commit bc63961 into main Jul 13, 2025
26 checks passed
@StephenHodgson StephenHodgson deleted the development branch July 13, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant