-
-
Notifications
You must be signed in to change notification settings - Fork 3
unity-setup@v1.1.1 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- add support for `modules: None` input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Unity Setup action to v1.1.1 and adds explicit support for passing modules: None. It unifies and exposes the install-path setter, adjusts module input parsing, and refines cleanup logic.
- Added
SetInstallPathand removed the duplicate lowercasesetInstallPath - Updated
ValidateInputsto special-case"None"modules and skip defaults when requested - Changed
getDefaultModulesdefaults to only include il2cpp per platform - Adjusted
removePathto acceptundefinedand only delete if the path exists
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/unity-hub.ts | Added SetInstallPath, removed duplicate setter, updated removePath |
| src/inputs.ts | Enhanced module parsing to handle "None", updated default modules |
| src/index.ts | Guarded installPath check and renamed to SetInstallPath |
| package.json | Bumped version from 1.1.0 to 1.1.1 |
| README.md | Fixed unity-version key naming in examples |
| .github/workflows/validate.yml | Updated matrix key names and added cases for modules: None |
Comments suppressed due to low confidence (2)
src/inputs.ts:16
- The
|| []is redundant becausegetArrayInputalways returns an array. You can remove the fallback to simplify the code.
const modulesInput = getArrayInput('modules') || [];
src/inputs.ts:140
- Previously the default modules included
androidandiosas well. Dropping them changes the out-of-the-box behavior—verify if this was intentional or restore the prior defaults.
return ['linux-il2cpp'];
modules: Noneinput