Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Livery Manager crashes with a livery file without liveries. #3

Closed
nic547 opened this issue Aug 28, 2020 · 0 comments · Fixed by #4
Closed

Livery Manager crashes with a livery file without liveries. #3

nic547 opened this issue Aug 28, 2020 · 0 comments · Fixed by #4

Comments

@nic547
Copy link
Contributor

nic547 commented Aug 28, 2020

When trying to run the software, it crashed before displaying the main window.
No errors appear in the logfile.
Using PS, I was able to get the attached stacktrace.
crash.zip

My livery file was empty (and is also attached). Adding a new livery in TSW2 fixes the crash. Removing it leads to the crash reappearing.
Seems like the in "LoadGameLiveries"-Method, the Start of Livery doesn't get found (i.e. LocateByteInArray returns -1) and then the creating an array of length -1 crashes the whole thing.
@nic547 nic547 changed the title Livery Manager crashes with an emtpy livery file. Livery Manager crashes with an livery file without liveries. Aug 28, 2020
@nic547 nic547 changed the title Livery Manager crashes with an livery file without liveries. Livery Manager crashes with a livery file without liveries. Aug 28, 2020
nic547 added a commit to nic547/TSW2-Livery-Manager that referenced this issue Aug 30, 2020
@nic547
Handle empty livery file
db98bd3 
fix RagingLightning#3
nic547 added a commit to nic547/TSW2-Livery-Manager that referenced this issue Aug 30, 2020
@nic547
Handle empty livery file
a4f5dda 
fix RagingLightning#3
@nic547 nic547 mentioned this issue Aug 30, 2020
Merged
RagingLightning added a commit that referenced this issue Sep 1, 2020
@RagingLightning
Merge pull request #4 from nic547/master
00d9418 
Handle empty livery file fixes #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle empty livery file nic547/TSW2-Livery-Manager
1 participant
@nic547