Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Fix a few patches #13

Merged
merged 1 commit into from Jun 25, 2019
Merged

common: Fix a few patches #13

merged 1 commit into from Jun 25, 2019

Conversation

@jonahbron
Copy link
Contributor

jonahbron commented Jun 23, 2019

No description provided.

@jonahbron jonahbron mentioned this pull request Jun 23, 2019
Copy link
Owner

Rahix left a comment

Thanks for the improvements! Apart from the two things I commented on, this is great!

patch/common/wdt.yaml Outdated Show resolved Hide resolved
patch/atmega328p.yaml Outdated Show resolved Hide resolved
@jonahbron jonahbron force-pushed the jonahbron:master branch from a6d80ff to 6cfea84 Jun 24, 2019
@@ -22,11 +22,11 @@ WDT:
description: "Watchdog Timer Prescaler - High Bit"
bitRange: "[5:5]"
WDPL:
CYCLES_2K: [0, "- 2048 cycles, ~16ms/512K (524288) cycles, ~4s if WDPH is set"]
CYCLES_4K: [1, "- 4096 cycles, ~32ms/1024K (1048576) cycles, ~8s if WDPH is set"]
CYCLES_8K: [2, "- 8192 cycles, ~64ms"]

This comment has been minimized.

Copy link
@jonahbron

jonahbron Jun 24, 2019

Author Contributor

Indented remaining lines to keep vertical alignment

@jonahbron

This comment has been minimized.

Copy link
Contributor Author

jonahbron commented Jun 24, 2019

@Rahix All comments addressed, thanks for your feedback.

@Rahix
Rahix approved these changes Jun 25, 2019
Copy link
Owner

Rahix left a comment

Looks good!

@Rahix Rahix changed the title Fixed some descriptions and added missing WDT options common: Fix a few patches Jun 25, 2019
@Rahix Rahix merged commit 1606c20 into Rahix:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.