New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve button wrapping behavior #1348

Merged
merged 1 commit into from Feb 27, 2017

Conversation

3 participants
@WesCossick
Contributor

WesCossick commented Feb 25, 2017

By wrapping the two "from" line buttons on the composition popup in a <span class="pull-right"> tag, they will now break lines together instead of separately. See below:

Before

before

After

after

@ervee

This comment has been minimized.

Contributor

ervee commented Feb 26, 2017

Hi Wes, great UI work I see from you. Thanks for chipping in.

On my screen (Sony Xperia Z5 compact, it looks like this.

screenshot_20170226-112310

There is so little room for showing the body of the email. Is that something that could be improved also?

@ervee

This comment has been minimized.

Contributor

ervee commented Feb 26, 2017

Ps, this is before your patch, which might improve it a little so I'll have to test that out.

@WesCossick

This comment has been minimized.

Contributor

WesCossick commented Feb 27, 2017

@ervee I definitely agree that the composition area for the message body can become too tiny. I'm looking into the best way of resolving that now. I think the root of the issue is that the dynamic min-height attribute has no enforced minimum, so it can be given a minimum height that is far too small to be useful.

However, this PR fixes a different bug that isn't really related.

@RainLoop RainLoop merged commit b854f93 into RainLoop:master Feb 27, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment