New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switch to enable or disable the Reply Counter #227

Closed
wants to merge 3 commits into
base: master
from

Conversation

3 participants
@ervee
Contributor

ervee commented Jul 4, 2014

I added an option to enable or disable the Reply Counter.

It is possible when you look at the code you will shake your head, but I gave it my best shot :)

As far as i could test it, it looks like it is working.

ervee added some commits Jul 4, 2014

modified: rainloop/v/0.0.0/app/templates/Views/App/SettingsGeneral.html
	modified:   rainloop/v/0.0.0/langs/en.ini
	modified:   rainloop/v/0.0.0/langs/nl.ini
modified: dev/Common/Utils.js
	modified:   dev/Settings/General.js
	modified:   dev/Storages/AbstractData.js
	modified:   dev/ViewModels/MailBoxMessageViewViewModel.js
@ervee

This comment has been minimized.

Contributor

ervee commented Jul 4, 2014

The LABEL_REPLY_COUNTER tag has only been added to the English and Dutch language files. Do you normally leave adding new tags up to the translators or pre-add it to the files? My vi stumbled over foreign character sets so I did not dare to add the tag to a log of other language files...

@ervee ervee referenced this pull request Jul 5, 2014

Closed

Stop editing subject on Reply #221

@rbeuque74

This comment has been minimized.

rbeuque74 commented Jul 5, 2014

For French language :
LABEL_REPLY_COUNTER = "Activer le compteur de réponses dans le sujet (Re[n])"

Thanks for the feature :)

@ervee

This comment has been minimized.

Contributor

ervee commented Jul 17, 2014

Hi @RainLoop, is my patch (see pull request) sufficient / acceptable by your standards? Or shal I revise my code change as suggested by kaustavdm in #221 ?

@RainLoop

This comment has been minimized.

Owner

RainLoop commented Jul 17, 2014

Thanks, but I do not want to add an extra setting for this.
BUT, I'll remove the Reply counter in the next version (today).

@RainLoop RainLoop closed this in cf80b8f Jul 17, 2014

@ervee ervee deleted the ervee:replycounter branch Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment