New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one non-steam game shortcut shows up in Rainway at a time. #254

Closed
BetaLeaf opened this Issue Sep 15, 2018 · 14 comments

Comments

Projects
None yet
5 participants
@BetaLeaf
Copy link

BetaLeaf commented Sep 15, 2018

Steps to trigger the problem that are specific, and repeatable

Add 2 or more non-steam games to steam as shortcuts then go to https://play.rainway.io and refresh the list of games.

What happens when you follow the steps, and what you expected to happen instead. Include the exact text of any error messages if applicable (or upload screenshots).

Expected:

All non-steam games should show up.

Reality:

Only the first game shows up. The game that shows up is determined by the shortcuts.vdf file.
"C:\Program Files (x86)\Steam\userdata\<SteamID>\config\shortcuts.vdf"

Did this work in a previous version? If so, also provide the version that it worked in.

I'm not 100% sure, but I think I've had this bug since the very beginning, when the open beta was launched.

OS version

Windows 10 Pro Version 1803 Build 17134.228

Extensions? Any browser extensions you might have installed.

Not Applicable due to server-side issue.
Lastpass: Free Password Manager, Rebrandly, Application Launcher for Drive (by Google)

Any errors logged in your Server.log file?

You can view my full log at ServerLog.7z
In particular, these lines stood out to me:

2018-09-14 22:53:56,233 [23] WARN Rainway.Core.Games.AnalyzerService - Found Pokemon Trading Card Game Online(59e1227013373b06f42a808929602f0e) via SteamShortcut
2018-09-14 22:53:57,198 [26] WARN Rainway.Core.Games.Analyzers.SteamShortcutAnalyzer - Skipping Remote Desktop because it's already added
2018-09-14 22:53:57,200 [26] WARN Rainway.Core.Games.Analyzers.SteamShortcutAnalyzer - Skipping Console because it's already added
2018-09-14 22:53:57,202 [26] WARN Rainway.Core.Games.Analyzers.SteamShortcutAnalyzer - Skipping Launchbox because it's already added

Was the error on a client/app or the server?

Server

Additional Notes

I have cleared cache via the tray icon several times.
I have done a clean reinstall of Rainway.
I have deleted and allowed steam to recreate the Shortcuts.vdf file.
I have tried Force Analyser Refresh in the tray icon.

@JTTM

This comment has been minimized.

Copy link

JTTM commented Sep 15, 2018

@healingbrew

This comment has been minimized.

Copy link
Member

healingbrew commented Sep 18, 2018

Does the shortcuts.vdf file have more than one shortcut?

@BetaLeaf

This comment has been minimized.

Copy link

BetaLeaf commented Sep 18, 2018

Yes it does. It has 4 entries:
Pokemon Trading Card Game Online
Remote Desktop
Console
Launchbox

shortcuts.zip

@healingbrew

This comment has been minimized.

Copy link
Member

healingbrew commented Sep 19, 2018

Is fixed in the next update.

@BetaLeaf

This comment has been minimized.

Copy link

BetaLeaf commented Sep 20, 2018

Thanks, Naomi. When does the next update launch? (rough eta is fine)

@JTTM

This comment has been minimized.

Copy link

JTTM commented Sep 20, 2018

@BetaLeaf

This comment has been minimized.

Copy link

BetaLeaf commented Sep 20, 2018

Thanks @JTTM
Wonder what the bug was. An issue in parsing the Shortcuts.vdf?

@Codeusa

This comment has been minimized.

Copy link
Member

Codeusa commented Sep 20, 2018

I used regular expressions to parse binary. @healingbrew has properly scolded me.

@BetaLeaf

This comment has been minimized.

Copy link

BetaLeaf commented Sep 20, 2018

Sure, you got scolded, but at least you came out of it and learned something from it. Anyways, glad the issue was fixed. Have a good day.

@healingbrew

This comment has been minimized.

Copy link
Member

healingbrew commented Sep 20, 2018

Actually the issue was a "filter" we implemented to strip out "weird" characters from a name because certain characters have issues encoding on .NET, but at some point it broke and removed all characters.

So that when we add a steam shortcut, it was checking if we already had a game with that title-- but since it's now an empty string it just stopped working after the first entry.

I rewrote the VDF parser from regex to a more sane parser to have some maintainability, which is a seperate concern.

@BetaLeaf

This comment has been minimized.

Copy link

BetaLeaf commented Sep 24, 2018

Confirmed fixed. Thanks.

@alekseyruzh

This comment has been minimized.

Copy link

alekseyruzh commented Sep 26, 2018

@healingbrew have added our non-steam indie game project as a shortcut to steam, the name is Encoder.exe, have also changed an icon inside the steam itself, still does not show up in my play.rainway.io

can you please help?

@BetaLeaf

This comment has been minimized.

Copy link

BetaLeaf commented Sep 26, 2018

@JTTM

This comment has been minimized.

Copy link

JTTM commented Sep 26, 2018

@alekseyruzh Please join the Discord https://rain.gg/discord for more help with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment