Local scope, page variables, and refactor; oh my!#12
Merged
Conversation
This increases the utility of the plugin by allowing the `url` parameter
to accept the name of a variable in the (first) local scope to its
rendering context. In other words, this allows uses such as:
```
{% assign url = page.calendar_address %}
{% ical url: url %}
...
{% endical %}
```
This is particularly useful for layouts, includes, and other non-leaf
areas of Jekyll's templating system in which it does not make sense to
hardcode a given iCalendar URL.
… into meitar-local-scope
…, and from page variables
Member
Author
|
Note @meitar I relaxed the jekyll version to support v3 and up. So you may be able to use the official gem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support many ways to set
urlfor theicaltagClose @11; Thanks @meitar
Version 1.0.9 will be published soon