Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test errors with 2018.06 #43

Closed
JJ opened this issue Aug 15, 2018 · 5 comments
Closed

Test errors with 2018.06 #43

JJ opened this issue Aug 15, 2018 · 5 comments
Assignees

Comments

@JJ
Copy link

JJ commented Aug 15, 2018

Which is weird, because it was working somewhere else. This is an Ubuntu 16.04 LTS

===SORRY!===
Function 'Pod::Defn' needs parens to avoid gobbling block (or perhaps it's a class that's not declared or available in this scope?)
at /home/jmerelo/progs/forks/perl6/Pod-To-HTML/lib/Pod/To/HTML.pm (Pod::To::HTML):147
------>         }⏏<EOL>
Missing block (apparently claimed by 'Pod::Defn')
at /home/jmerelo/progs/forks/perl6/Pod-To-HTML/lib/Pod/To/HTML.pm (Pod::To::HTML):147
------>         }⏏<EOL>

===> Testing [FAIL]: Pod::To::HTML:ver<0.3.21>
Aborting due to test failure: Pod::To::HTML:ver<0.3.21> (use --force-test to override)
@JJ
Copy link
Author

JJ commented Aug 15, 2018

I'm compiling again 2018.06. Maybe I didn't have the latest version or something...

@JJ
Copy link
Author

JJ commented Aug 15, 2018

Same thing. Do I need to install master?

@zoffixznet
Copy link

That class is undefined and looking at earlier changes by @jonathanstowe looks like it should be named Pod::DefnList instead.

JJ added a commit to JJ/Pod-To-HTML that referenced this issue Aug 15, 2018
@JJ
Copy link
Author

JJ commented Aug 15, 2018

In fact, Rakudo includes Pod::Defn but the problem is that the version I have does not return that yet. Was that released?

@zoffixznet
Copy link

Ah. No, it existed in Rakudo only for 13 days.

The module should either be patched with a backcompat shim or the changes reverted entirely. It's required by p6doc and a couple of other modules, which means they're now broken.

@zoffixznet zoffixznet self-assigned this Aug 15, 2018
softmoth added a commit to softmoth/raku-Pod-To-Markdown that referenced this issue Apr 5, 2021
The handling of the fake Pod::Defn for older compilers is just copied
from Raku/Pod-To-HTML#43. Probably it isn't
needed anymore, nobody is still using that old of a compiler. But it
doesn't hurt.

The :formatting<B> config is not documented explicitly for =defn, and
I've chosen to use it to format only the term, not the definition.

Fixes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants