Update HTML.pm #25
Closed
Update HTML.pm #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group multis together, change a multi to a switch, utilize samewith instead of recurse, s/returns/--> Str/
zoffixznet
reviewed
Feb 24, 2017
There was a problem hiding this comment.
Overall, I suspect this has a measurable negative performance impact and our docs build is slow as it is. I'd suggest measuring what that impact is first.
The multi code can be cleaned up by using captures instead:
multi method render(Array $pod, |c) { pod2html $pod, |c }
Although that'd make less-obvious error messages when incorrect args are given.
| } | ||
| when Pod::Block { | ||
| pod2html($pod, :$header, :$footer, :$head, :$default-title, :$lang) | ||
| } |
There was a problem hiding this comment.
+ when Array {
+ pod2html($pod, :$header, :$footer, :$head, :$default-title, :$lang)
+ }
+ when Pod::Block {
+ pod2html($pod, :$header, :$footer, :$head, :$default-title, :$lang)
+ }
that can be written as just
when Array | Pod::Block { pod2html($pod, :$header, :$footer, :$head, :$default-title, :$lang)}
| } | ||
| when Str { | ||
| use MONKEY-SEE-NO-EVAL; | ||
| pod2html(EVAL($pod-string ~ "\n\$=pod"), :$header, :$footer, :$head, :$default-title, :$lang); |
There was a problem hiding this comment.
You still use $file and $pod-string here, despite changing the variable name to $pod. Please run make test on the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group multis together, change a multi to a switch, utilize samewith instead of recurse, s/returns/--> Str/