fixes issues #275 and #279 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both issues stem from the same problem: text is included in a secondary file from a primary file from a level2 heading. But the section is terminated by a level1 heading, not a level2 heading. The fix is to look for leveln, n-1, n-2, n-3 headings. By specification of RakuDoc, only headings upto level 4 are distinguished. The regex should be made more generic, perhpas by recursion on level, decrementing it to 0, but I don't know how.
|
@coke this fix is not related to any of the UX changes. Would you please review it, and authorise. It is a change to a Regex |
coke
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both issues stem from the same problem: text is included in a secondary file from a primary file from a level2 heading. But the section is terminated by a level1 heading, not a level2 heading. The fix is to look for leveln, n-1, n-2, n-3 headings. By specification of RakuDoc, only headings upto level 4 are distinguished. The regex should be made more generic, perhpas by recursion on level, decrementing it to 0, but I don't know how.