Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use File::Temp, not .pick #1062

Closed
coke opened this issue Dec 19, 2016 · 4 comments
Closed

use File::Temp, not .pick #1062

coke opened this issue Dec 19, 2016 · 4 comments
Assignees
@coke

Comments

@coke
Copy link
Collaborator

coke commented Dec 19, 2016

We're currently relying on a random number to generate a temp file. Should use the ecosystem module.
@coke coke added the build label Dec 20, 2016
@coke coke assigned coke and unassigned coke Dec 20, 2016
Altai-man added a commit that referenced this issue Dec 22, 2016
@Altai-man
Replace random .pick with File::Temp usage.
7f87d5e 
Fix for #1062
@Altai-man Altai-man mentioned this issue Dec 22, 2016
Closed
@MasterDuke17
Copy link
Contributor

I haven't looked at the recent commit, but I've run into a problem with File::Temp before (perlpilot/p6-File-Temp#18) and suggest someone make sure that won't be an issue with the way it's used here.

@coke
Copy link
Collaborator Author

coke commented Dec 22, 2016

While we're in there, we should also not use 'pyg' anymore, since we're using highlights now.

@coke coke self-assigned this Dec 22, 2016
@coke coke removed their assignment Dec 29, 2017
@AlexDaniel
Copy link
Member

There's also https://github.com/zoffixznet/perl6-Temp-Path

@coke coke self-assigned this Apr 10, 2018
@coke
Copy link
Collaborator Author

coke commented Apr 10, 2018

We already have a dep on File::Temp, in use by one of the test files.

@coke coke closed this as completed in 6358bdd Apr 10, 2018
coke added a commit that referenced this issue Apr 11, 2018
@coke
Close out unused filehandle so we don't leak.
003da56 
Part of #1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coke coke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coke @AlexDaniel @MasterDuke17