Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search box occasionally does not show up #117

Closed
moritz opened this issue Aug 22, 2015 · 3 comments
Closed

Search box occasionally does not show up #117

moritz opened this issue Aug 22, 2015 · 3 comments

Comments

@moritz
Copy link
Collaborator

moritz commented Aug 22, 2015

When I load http://perl6.org/ by entering the URL, the search box doesn't show up; when I follow a link to another page, it shows up on that page, and when I then follow a link to the front page, it shows up again. When reloading the front page, it occasionally shows up, but not always.

Others have reported similar issues for other pages as well.
@moritz
Copy link
Collaborator Author

moritz commented Aug 22, 2015

Firebug says in the console window:

ReferenceError: jQuery is not defined
ReferenceError: $ is not defined

@moritz
Copy link
Collaborator Author

moritz commented Aug 22, 2015

... probably because the jquery .js is included with async, so it might not be available at the time search.js is included.

@laben
Copy link

laben commented Aug 22, 2015

I can confirm the issue. Trying to force-reload with Ctrl+F5 in Chrome shows perfectly that the search box does not appear half the times.

moritz added a commit that referenced this issue Aug 22, 2015
@moritz
Avoid Javascript error
6c72b35 
search.js / search_template.js uses jquery for running JS when the
document is ready, but cannot use jQuery for that, because jQuery is lazily
loaded, and thus might not be available yet (#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moritz @AlexDaniel @laben