Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IO::Socket::Async first example more explicit #1213

Closed
1 of 3 tasks
trosel opened this issue Feb 23, 2017 · 3 comments
Closed
1 of 3 tasks

Make IO::Socket::Async first example more explicit #1213

trosel opened this issue Feb 23, 2017 · 3 comments
Labels
docs Documentation issue (primary issue type) good first issue If you want to dive in, this would be a good place to start

Comments

@trosel
Copy link
Contributor

trosel commented Feb 23, 2017 •
edited by rafaelschipiura

https://github.com/perl6/doc/blob/master/doc/Type/IO/Socket/Async.pod6#L32

  • change $p to $promise
  • change anonymous block to a pointy block with a good name. Does the promise return the listening socket, or does it return the connecting socket? I think it returns the connecting socket because it is printing to the listening socket and then it closes itself after it gets a response.
  • Clear up where .Supply is coming from? The listening socket, I would presume.
@trosel trosel added docs Documentation issue (primary issue type) LHF labels Feb 23, 2017
lancew added a commit to lancew/doc that referenced this issue Sep 3, 2017
@lancew
Change $p to $promise in Async documentation
d3c7dab 
As per Issue Raku#1213, change the use of $p to $promise to make it
more expressive.
@lancew lancew mentioned this issue Sep 3, 2017
Merged
moritz pushed a commit that referenced this issue Sep 3, 2017
@lancew @moritz
Change $p to $promise in Async documentation
a5be0ce 
As per Issue #1213, change the use of $p to $promise to make it
more expressive.
@lancew
Copy link
Contributor

lancew commented Sep 3, 2017

Can be closed?

@moritz
Copy link
Collaborator

moritz commented Sep 3, 2017

Sure, feel free!

@lancew lancew closed this as completed Sep 3, 2017
@trosel
Copy link
Contributor Author

trosel commented Sep 5, 2017

@lancew any thoughts on my other two checklist items?

@coke coke added good first issue If you want to dive in, this would be a good place to start and removed LHF labels Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation issue (primary issue type) good first issue If you want to dive in, this would be a good place to start
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lancew @moritz @coke @trosel