Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented :translate-nl option to Str.encode #1233

Closed
zoffixznet opened this issue Mar 4, 2017 · 8 comments
Closed

Undocumented :translate-nl option to Str.encode #1233

zoffixznet opened this issue Mar 4, 2017 · 8 comments
Assignees
Labels
update part of "docs" - indicates this is an update for an existing section; rewrite, clarification, etc.

Comments

@zoffixznet
Copy link
Contributor

Added to Rakudo in rakudo/rakudo@0a2eef8 but isn't documented.

@jnthn
Copy link
Contributor

jnthn commented Mar 4, 2017

For what it's worth, it's not in roast either yet - which in turn reflects that I'm still pondering whether it's the right name and the right peg to hang it on.

@zoffixznet
Copy link
Contributor Author

It's kinda long to type :)

@AlexDaniel AlexDaniel added the NOTSPECCED need roast tests before documenting label Mar 4, 2017
@jnthn
Copy link
Contributor

jnthn commented Mar 4, 2017

I don't expect it to be typed often. :-) I was wondering if translate-crlf would be more clear what it's about.

@jnthn
Copy link
Contributor

jnthn commented Mar 4, 2017

By the way, the reason I don't expect it to be typed often is because most encoding happens at I/O boundaries, and we can make good defaults for 99% of cases (we already do so). So this would mostly be relevant to folks who are implementing their own I/O-like things. Not entirely common.

@JJ
Copy link
Contributor

JJ commented Jun 7, 2018

Still not in roast. Would it be worth the while to document it now, indicating it's Rakudo-specific?

@jnthn
Copy link
Contributor

jnthn commented Jun 7, 2018

I think, having had time to get used to the name, we can roast it. We still need to do an audit of the various IO types where it might be used and make sure they expose it and pass it along to the decoders and encoders. I don't know if on handles or similar where you can read and write we should expose an in and out form. But for the decoder case of it as being discussed here, then it's pretty clear there's only one thing it's talking about.

@JJ
Copy link
Contributor

JJ commented Jun 7, 2018 via email

@JJ JJ added update part of "docs" - indicates this is an update for an existing section; rewrite, clarification, etc. and removed NOTSPECCED need roast tests before documenting labels Aug 8, 2018
@JJ
Copy link
Contributor

JJ commented Aug 8, 2018

It's now in roast after above PR was accepted, so I'll proceed to document it.

@JJ JJ self-assigned this Aug 8, 2018
JJ added a commit that referenced this issue Aug 9, 2018
@JJ JJ closed this as completed in 9ec88b2 Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update part of "docs" - indicates this is an update for an existing section; rewrite, clarification, etc.
Projects
None yet
Development

No branches or pull requests

4 participants