Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enums of in the IO::Notification searchable #1558

Closed
gfldex opened this issue Sep 16, 2017 · 4 comments
Closed

Make enums of in the IO::Notification searchable #1558

gfldex opened this issue Sep 16, 2017 · 4 comments
Assignees
Labels
good first issue If you want to dive in, this would be a good place to start

Comments

@gfldex
Copy link
Contributor

gfldex commented Sep 16, 2017

Please mind the enum!

@rafaelschipiura rafaelschipiura added the docs Documentation issue (primary issue type) label Sep 16, 2017
@JJ
Copy link
Contributor

JJ commented Apr 14, 2018

What do you mean here?

@JJ JJ self-assigned this Apr 14, 2018
@AlexDaniel
Copy link
Member

This ticket is about this, I think. There are some tests in roast here.

@JJ
Copy link
Contributor

JJ commented Apr 14, 2018

Still. Rewrite documentation? Add an example?

@AlexDaniel
Copy link
Member

Oh, damn you're right. So IO::Notification is already doc-ed and IO::Notification::Change links to IO::Notification. That's good.

But there's this enum:

my enum FileChangeEvent (:FileChanged(1), :FileRenamed(2));

And I would say that FileChangeEvent, FileChanged, and FileRenamed should all be searchable. Once they are, feel free to close. I see nothing else to do here.

@AlexDaniel AlexDaniel added search good first issue If you want to dive in, this would be a good place to start and removed docs Documentation issue (primary issue type) labels Apr 14, 2018
@JJ JJ changed the title doc IO::Notification::Change Make enums of in the IO::Notification searchable Apr 14, 2018
@JJ JJ removed the JJ TPF Grant label May 14, 2018
@JJ JJ closed this as completed in 0264be3 Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue If you want to dive in, this would be a good place to start
Projects
None yet
Development

No branches or pull requests

4 participants