Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be mindful of external references when breaking links #1838

Closed
zoffixznet opened this issue Mar 9, 2018 · 8 comments
Closed

Be mindful of external references when breaking links #1838

zoffixznet opened this issue Mar 9, 2018 · 8 comments
Labels
big Issue consisting of many subissues

Comments

@zoffixznet
Copy link
Contributor

zoffixznet commented Mar 9, 2018

I noticed a commit fixed some links that are 404s and I clearly remembered using those links recently-ish, but I can't remember where exactly. It could've been a blog post, a response on social media, or an email. Regardless of what it was, those links are now broken due to some changes to our site.

We should be more mindful when changing links. If we're to fulfill the Vision for the site, we can't continually break 3rd party communications and content (especially tutorials, blogs, videos, and books).

That point should be made in the contributing guide and some common forms of links should probably be tested (e.g. /type/ and /routine/ links). For example, https://docs.perl6.org/type/Proc$COLON$COLONAsync used to be a working link and I even remember adding .htaccess rewrite rules to keep that form working when we got rid of $COLON stuff in URLs. However, it appears a more recent commit to .htaccess broke those rewrites


I ran a small Perl 6 one liner over the content of my 2-year old blog and these links turned up as broken:

The pages for https://docs.perl6.org/syntax/CONTROL and https://docs.perl6.org/syntax/LEAVE now require a space before the keyword so those two along with the $COLON stuff looks to me like accidental breakage of external links that should've been caught by something IMO.

@zoffixznet zoffixznet added the site label Mar 9, 2018
@JJ
Copy link
Contributor

JJ commented Mar 9, 2018

Hum. That would explain lots of things...

@JJ
Copy link
Contributor

JJ commented Mar 9, 2018

Could this be related to #1835 ?

@JJ
Copy link
Contributor

JJ commented Mar 9, 2018

This is definitely related to this:

https://docs.perl6.org/routine/.$CIRCUMFLEX_ACCENT	
  Line: 158
  Code: 404 Not Found
 To do: The link is broken. Double-check that you have not made any typo,
	or mistake in copy-pasting. If the link points to a resource that
	no longer exists, you may want to remove or fix the link.

@JJ
Copy link
Contributor

JJ commented Mar 9, 2018

And... It might have caused the Great Broken Link Explosion... #561
screenshot from 2018-03-09 20 05 17
Pretty much matches the dates...

@JJ
Copy link
Contributor

JJ commented Mar 10, 2018

Could we maybe add a xt test to check for this kind of things?

@JJ
Copy link
Contributor

JJ commented Mar 12, 2018

What is your suggestion in this case? Should we revert the change in .htaccess? Should we try and combine the two to see what happens?

@JJ JJ added the TPF Grant label Mar 28, 2018
@JJ JJ added the big Issue consisting of many subissues label Apr 9, 2018
zoffixznet added a commit that referenced this issue Apr 9, 2018
Debug attempt for #1838

We write search.js to html/js, but ever since assets were
moved into being generated by an app[^1], this dir is gone
from the repo, which causes `make html` fail to build search file.

[1] f856a13ec12aa2abe0918
@JJ
Copy link
Contributor

JJ commented May 1, 2018

We should also try and have some test files for this.

@JJ JJ removed the JJ TPF Grant label May 14, 2018
JJ added a commit that referenced this issue Aug 28, 2018
Refs #561 #1838, but mainly it's been a very extensive reflow, there were very long lines here. Main intention was to work towards #2283
@coke
Copy link
Collaborator

coke commented Feb 8, 2023

The original breakages are unfortunately long gone at this point.

Going forward, we can do better to not break old links, and the new raku/doc-website will have a link checker available, and hopefully we can also track web server log info and track 404s so we can fix breakages sooner.

@coke coke closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big Issue consisting of many subissues
Projects
None yet
Development

No branches or pull requests

3 participants