Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pages are not indexed. #1894

Closed
JJ opened this issue Apr 3, 2018 · 9 comments
Closed

Some pages are not indexed. #1894

JJ opened this issue Apr 3, 2018 · 9 comments
Assignees
Labels
big Issue consisting of many subissues

Comments

@JJ
Copy link
Contributor

JJ commented Apr 3, 2018

From #1893 I've realized the terms indexed there are not included in the search file for some reason. There are quite a few of them. I'm not sure why this happens, or since when it's happening. It's related to htmlify.p6 for sure, but...
At least, these pages are not indexed:

  • operators
  • glossary
  • classtut
  • typesystem
    Please edit this to add some others when you find something is missing.
@JJ JJ added big Issue consisting of many subissues search labels Apr 3, 2018
@JJ
Copy link
Contributor Author

JJ commented Apr 3, 2018

This is the kind of code I mean

X<Zip operator>

does not create a Zip operator entry in the index, for instance.

@JJ
Copy link
Contributor Author

JJ commented Apr 3, 2018

I'm checking other lines, which are theoretically correct, which have the same problem... Por instance, this zip Meta Operator https://github.com/perl6/doc/blob/87fafef7c37eee1694d490307c58856113585bc5/doc/Language/operators.pod6#L416
Is this new?

@JJ JJ changed the title Refactoring of the operators.pod6 page. The operators.pod6 page is not indexed. Apr 3, 2018
@nxadm
Copy link
Contributor

nxadm commented Apr 6, 2018

The search part of the following issue is related, the naming (>> vs >>.) isn't:
#562

@JJ JJ changed the title The operators.pod6 page is not indexed. Lots of pages are not indexed. Apr 9, 2018
@JJ
Copy link
Contributor Author

JJ commented Apr 9, 2018

Many entries in many pages are not indexed, including operators.pod6, classtut.pod6, and (maybe) others...

JJ added a commit that referenced this issue Apr 9, 2018
Which goes towards #1912 but it useless anyway because #1894
@JJ JJ changed the title Lots of pages are not indexed. Some pages are not indexed. Apr 9, 2018
@zoffixznet
Copy link
Contributor

FWIW, if I delete all but one files in doc/Type/* and doc/Language and leave doc/Language/operators in and then stick a print after find-definitions ( https://github.com/perl6/doc/blob/11e7bc900a5fb825345b3e377844a6c5b00918cb/htmlify.p6#L319 ) that print never occurs, as if find-definitions never returns.

If I comment out this part inside find-definitions and everything that depends on it, then the routine returns and indices get printed.

The problematic bit seems to be $origins. If I try to dump it, I get an infinilooping dump.

@JJ
Copy link
Contributor Author

JJ commented Apr 9, 2018

I really don't like to be working with the dynamic $*DR variable. It's just a global variable in disguise. Not clear what's happening where. It's my first target for refactoring.

@JJ
Copy link
Contributor Author

JJ commented Apr 26, 2018

I don't know if they are increasing or what... I keep finding more and more.

@coke
Copy link
Collaborator

coke commented Apr 26, 2018

This may be related to #1938 - some pages are not getting processed, and the errors are being hidden by the use of Promise.allof

@JJ
Copy link
Contributor Author

JJ commented Apr 27, 2018

We would need to do1932. When it fails, it does so silently.

@zoffixznet zoffixznet self-assigned this Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big Issue consisting of many subissues
Projects
None yet
Development

No branches or pull requests

4 participants