Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated index entries and avoid them in the future by adding a test. #1912

Open
17 tasks done
JJ opened this issue Apr 9, 2018 · 8 comments
Open
17 tasks done
Assignees
Labels
bug Error of some kind, from a typo to errors in the examples. xt Regarding current or new xt/ tests or the utils/

Comments

@JJ
Copy link
Contributor

JJ commented Apr 9, 2018

When doing make

  • found duplicate index entry is (inheritance) at #i45 #i679
  • found duplicate index entry :{} at #i853 #i855
  • found duplicate index entry compunit at #i276 #i277 #i278
  • found duplicate index entry declarator regex at #i258 #i594
  • found duplicate index entry increment operator at #i361 #i365
  • found duplicate index entry control flow at #i53 #i54 #i55 #i56 #i58 #i60 #i61 #i65 #i68 #i69 #i71 #i74 #i75 #i76 #i77 #i78 #i79 #i80 #i81
  • found duplicate index entry decrement operator at #i363 #i366
  • found duplicate index entry compunit at #i273 #i274 #i275
  • found duplicate index entry sym at #i260 #i263
  • found duplicate index entry ++ at #i360 #i364
  • found duplicate index entry whenever at #i50 #i51
  • found duplicate index entry NFG at #i214 #i851
  • found duplicate index entry «=» at #i430 #i765
  • found duplicate index entry ∅ at #i628 #i733
  • found duplicate index entry prefix & at #i129 #i871
  • found duplicate index entry $*USAGE at #i147 #i836
  • found duplicate index entry invocant at #i39 #i498

Among the gaggle of errors and warnings that pod2onebigpage emits. That would need a separate issue, or just point to #1823.
This error is also found in #1910

@JJ
Copy link
Contributor Author

JJ commented Apr 9, 2018

For instance, the first:

$ grep X doc/*/*.pod6 | grep inheritance
doc/Language/classtut.pod6:X<|is (inheritance)>
doc/Language/typesystem.pod6:The L<trait|/type/Sub#Traits> X<C<is>|is (inheritance)> accepts a type object to be

There should be some test for this, I guess...

JJ added a commit that referenced this issue Apr 9, 2018
Which goes towards #1912 but it useless anyway because #1894
@JJ JJ added bug Error of some kind, from a typo to errors in the examples. JJ TPF Grant labels Apr 13, 2018
@tisonkun
Copy link
Member

Eliminates :{} duplicate 0a92a89

tisonkun added a commit that referenced this issue Apr 16, 2018
JJ added a commit that referenced this issue Apr 18, 2018
Because the code that generates indexes is terra incognita and changing the grammar declarator from one place to another leads to errors. Change related to #1912 remains in place.
JJ added a commit that referenced this issue Apr 25, 2018
JJ added a commit that referenced this issue Apr 25, 2018
JJ added a commit that referenced this issue Apr 26, 2018
Closes #1967

Also refs #1912 because regex was repeated.
JJ added a commit that referenced this issue Apr 29, 2018
@JJ JJ closed this as completed in d32e413 Apr 30, 2018
@JJ JJ reopened this Jan 15, 2019
@JJ
Copy link
Contributor Author

JJ commented Jan 15, 2019

Duplicate index entries are back with a vengeance. We should not only eliminate them, but add a test so that they don't happen again. And in order to do that we need clear indexing specs, which we don't now.

@JJ JJ changed the title Duplicated index entries Fix duplicated index entries and avoid them in the future by adding a test. Jan 15, 2019
@JJ
Copy link
Contributor Author

JJ commented Jan 15, 2019

These are the duplicated index entries right now:

found duplicate index entry say (Basics) at #i27 #i28
found duplicate index entry Python at #i43 #i44 #i45 #i46 #i47 #i48 #i49
found duplicate index entry «=» at #i404 #i856
found duplicate index entry declarator at #i325 #i326
found duplicate index entry »=« at #i403 #i857
found duplicate index entry whenever at #i99 #i100
found duplicate index entry $*USAGE at #i94 #i927

Besides, the message about duplicated entries is cryptic. I have no idea where they are...

@JJ
Copy link
Contributor Author

JJ commented Jun 12, 2019

Please take this into account @antoniogamiz when working with the new Perl6::Documentable #1937

@antoniogamiz
Copy link
Contributor

antoniogamiz commented Jul 9, 2019

Well, I have been investigating and it looks like the ``#ixxx` corresponds to the position of that reference in the general TOC of BigPage.

I have made a script to find them with a clearer output => https://gist.github.com/antoniogamiz/8b628a274954adb5f364322615a159b5.

This is the output:

found duplicates of $*USAGE at variables variables create-cli
found duplicates of »=« at unicode_ascii operators
found duplicates of $*COLLATION at variables Any
found duplicates of Python at py-nutshell py-nutshell py-nutshell py-nutshell py-nutshell py-nutshell py-nutshell
found duplicates of PERL6LIB at 5to6-nutshell 03-environment-variables
found duplicates of say (Basics) at 101-basics 101-basics
found duplicates of declarator at functions functions
found duplicates of «=» at unicode_ascii operators

I will add it as a test in the new site.

@Altai-man
Copy link
Member

@coke this might be interesting, I guess we can just copy the script to the repo xt and close the ticket?

@coke coke self-assigned this Jun 19, 2022
@coke
Copy link
Collaborator

coke commented Jun 19, 2022

Probably requires slightly more updates than that, but yes, let's add it to xt/

@coke coke removed their assignment Aug 15, 2023
@coke coke removed the Priority label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error of some kind, from a typo to errors in the examples. xt Regarding current or new xt/ tests or the utils/
Projects
None yet
Development

No branches or pull requests

6 participants
@JJ @coke @Altai-man @tisonkun @antoniogamiz and others