Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent capitalization for doc headers #1945

Closed
Kaiepi opened this issue Apr 20, 2018 · 9 comments · Fixed by #2485
Closed

Inconsistent capitalization for doc headers #1945

Kaiepi opened this issue Apr 20, 2018 · 9 comments · Fixed by #2485
Labels
good first issue If you want to dive in, this would be a good place to start meta RFCs, general discussion, writing style, repository organization, etc.

Comments

@Kaiepi
Copy link
Collaborator

Kaiepi commented Apr 20, 2018

I've seen doc headers capitalized like this:

  • Foo bar baz
  • Foo Bar Baz

Which way of capitalizing them would be more appropriate?

@JJ
Copy link
Contributor

JJ commented Apr 21, 2018

The most consistent one. And I would say that would be the second, since we're capitalizing parts of generated headers.

@JJ JJ added meta RFCs, general discussion, writing style, repository organization, etc. JJ TPF Grant labels Apr 21, 2018
@coke
Copy link
Collaborator

coke commented Apr 23, 2018

Can you provide some concrete examples here? In general, we shouldn't overcapitalize just because something is in a header; initial cap should be fine.

@Kaiepi
Copy link
Collaborator Author

Kaiepi commented Apr 23, 2018

The NativeCall documentation sometimes only capitalizes the first word and sometimes uses title case:

  • Changing names
  • Passing and Returning Values
  • Basic use of Pointers

Ditto the Community page:

  • The Perl 6 community
  • Perl 6 Weekly

@JJ
Copy link
Contributor

JJ commented Apr 23, 2018 via email

@Kaiepi
Copy link
Collaborator Author

Kaiepi commented Apr 23, 2018

Would using something like :ignore-case to skip testing a header for title case be reasonable? That could possibly allow all headers to be testable

@JJ
Copy link
Contributor

JJ commented May 2, 2018

@Kaiepi reasonable, yes; feasible, I don't know. Problem with new tests is that they're bound to fail a lot, so they would have to be introduced first as author tests, then insert that into the guidelines, then move them to t/ And I don't see a big consensus here with that.

@coke
Copy link
Collaborator

coke commented May 2, 2018

We’ve dealt with this with many new xt/ tests. Skip all the failing files; force any new changes to conform. Slowly remove skips as updates are made to the files. Ticket stays open until skips are gone.

@JJ JJ added the good first issue If you want to dive in, this would be a good place to start label May 6, 2018
@JJ JJ removed the JJ TPF Grant label May 14, 2018
JJ added a commit that referenced this issue Jul 10, 2018
@MorayJ
Copy link
Contributor

MorayJ commented Sep 14, 2018

Should this be closed, or is there more to be done?

@JJ
Copy link
Contributor

JJ commented Sep 14, 2018

I'm not sure all the hash links have been fixed, although @uzluisf has made a pretty good job out of it. Anyway, that's kind of tangential, so feel free to close it if you think it's OK. We can always open it back at a later date or simply reference it if we make some change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue If you want to dive in, this would be a good place to start meta RFCs, general discussion, writing style, repository organization, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants