Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/Perl6/Documentable/Registry.pm fails at runtime #227

Closed
gfldex opened this issue Dec 7, 2015 · 5 comments
Closed

lib/Perl6/Documentable/Registry.pm fails at runtime #227

gfldex opened this issue Dec 7, 2015 · 5 comments

Comments

@gfldex
Copy link
Contributor

gfldex commented Dec 7, 2015

on This is rakudo version 2015.11-402-g67202d6 built on MoarVM version 2015.11-34-gc3eea17 implementing Perl v6.b.

Processing Language Pod files ...
1/32: doc/Language/5to6-nutshell.pod => language/5to6-nutshell
2/32: doc/Language/5to6-perlfunc.pod => language/5to6-perlfunc
3/32: doc/Language/5to6-perlop.pod => language/5to6-perlop
4/32: doc/Language/5to6-perlsyn.pod => language/5to6-perlsyn
5/32: doc/Language/5to6-perlvar.pod => language/5to6-perlvar
6/32: doc/Language/about.pod => language/about
7/32: doc/Language/classtut.pod => language/classtut
8/32: doc/Language/concurrency.pod => language/concurrency
9/32: doc/Language/containers.pod => language/containers
10/32: doc/Language/control.pod => language/control
11/32: doc/Language/exceptions.pod => language/exceptions
12/32: doc/Language/faq.pod => language/faq
13/32: doc/Language/functions.pod => language/functions
14/32: doc/Language/glossary.pod => language/glossary
15/32: doc/Language/grammars.pod => language/grammars
Type check failed in assignment to @!categories; expected Str but got Array
in method add-new at /home/dex/projekte/perl6/doc/lib/Perl6/Documentable/Registry.pm:12
in block at htmlify.p6:451
in sub find-definitions at htmlify.p6:358
in sub process-pod-source at htmlify.p6:220
in sub process-pod-dir at htmlify.p6:176
in sub MAIN at htmlify.p6:123
in block at htmlify.p6:808

@sylvarant
Copy link
Contributor

I have the exact same issue for:

$ perl6 --version
> This is rakudo version 2015.11-477-gde52f97 built on MoarVM version 2015.11-34-gc3eea17 implementing Perl v6.b.

pdl added a commit to pdl/doc that referenced this issue Dec 13, 2015
zoffixznet added a commit that referenced this issue Dec 13, 2015
@smls
Copy link
Contributor

smls commented Dec 17, 2015

smls added a commit that referenced this issue Dec 17, 2015
It didn't actually fix the problem, just hid it and replaced it with
a new problem by causing us to run into Rakudo bug RT 126951. Not to
mention it made the hash definitions kinda ugly.

This reverts commit b45a10e.
smls added a commit that referenced this issue Dec 17, 2015
The problem is that when pre-building the attribute hash and then
creating the Perl6::Documentable object with .new(|%args), array
values are itemized by he hash, and thus the wrong thing happens
when the default constructor assigns them to the respective
array attributes of the class via single-argument rule.

This commit overrides the default constructor to remove the
itemization, which fixes the problem.

A better long-term solution might be to refactor htmlify.p6 to not
pre-build the attribute initialization lists as hashes.
@sylvarant
Copy link
Contributor

I can confirm that

make html

now works on my machine.
Btw, shouldn't travis run make html, to keep track of it working ?

@jonathanstowe
Copy link
Contributor

👍 to testing this on travis

@awwaiid
Copy link
Contributor

awwaiid commented Dec 21, 2015

Seems ok now, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants