Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: please list the subsets for Real #2315

Closed
ToddAndMargo opened this issue Sep 17, 2018 · 12 comments
Closed

RFE: please list the subsets for Real #2315

ToddAndMargo opened this issue Sep 17, 2018 · 12 comments

Comments

@ToddAndMargo
Copy link

Request for Enhancement:

On https://docs.perl6.org/type/Real, you have to wade all the way down to find the subsets of what classes "Real" includes.

https://docs.perl6.org/type/Real#Type_Graph
Which is blurry and difficult to read.

It is not readily apparent what you are looking at.

Would you consider adding to the top of the page:

"Real" is a "Role" that includes the following classes: FatRat, Rat, Rational, Duration, Instant, Int, PromizeStatus, Bool, Automicint, Sinval, Order, InStr, NumStr, Num

I may have misspelled some of them, as the graph is blurry

@JJ
Copy link
Contributor

JJ commented Sep 17, 2018

You can click on stand-alone image to get it full size. Still, Real says:

Common role for non-Complex numbers.

All those numbers you mention are non-Complex, so they are included. It's a more precise and compact description. They are not "subsets". All those classes mix in or do that particular role.

Type graphs are always on the bottom of the page, so that they don't get in the way of the actual documentation. As indicated, they can be accessed in full size just by clicking on the link. It's rendered in vector graphics, so I can't really see how it can be blurry; it does not get more crisp than vector graphics.
So I'm afraid I'm also closing this one.

@JJ JJ closed this as completed Sep 17, 2018
@ToddAndMargo
Copy link
Author

ToddAndMargo commented Sep 17, 2018 via email

@AlexDaniel AlexDaniel reopened this Sep 17, 2018
@AlexDaniel
Copy link
Member

@JJ If you open javadoc for Number, you're immediately presented with:

Direct Known Subclasses:
AtomicInteger, AtomicLong, BigDecimal, BigInteger, Byte, Double, Float, Integer, Long, Short

So the idea of wanting to see subclasses without having to scroll is not that unusual. I don't know if we want to do the same in perl6 docs, but the ticket by itself is a valid request that should be considered.

@JJ
Copy link
Contributor

JJ commented Sep 17, 2018

I don't know who does javadoc for Number. I don't know what principles they follow, or if they have a quite clear type graph, which not only lists known subclasses, but known siblings and known superclasses and all kinds of things. I wasn't here when it was decided, but someone Who Knows decided that, instead of listing every single known subclass, by hand, we were going to do something which is infinitely better, automatically maintained and not prone to error: generate a Type Graph. The Type Graph has all that information and, as said above, then some.
So no, we don't want to do the same in Perl 6 docs which is why I closed the ticket. And this is what I'm doing again.
If you want to open another different ticket saying "Repeat in every Role all the known classes that mix it in, or include in every class all known classes that subclass it" please do so by all means. That's another reason why this ticket is closed. If we are going to do that, we should do it, for simple coherency, for all classes and roles, and of course do it automatically.

@JJ JJ closed this as completed Sep 17, 2018
@ToddAndMargo
Copy link
Author

ToddAndMargo commented Sep 17, 2018 via email

@AlexDaniel
Copy link
Member

I really think that there is still something to discuss in this ticket.

@AlexDaniel AlexDaniel reopened this Sep 17, 2018
@MorayJ
Copy link
Contributor

MorayJ commented Sep 18, 2018

If you want to open another different ticket saying "Repeat in every Role all the known classes that mix it in, or include in every class all known classes that subclass it" please do so by all means

I agree with JJ. There's no point having this as a stand alone issue for this page. It would have to change across all the pages and I'd welcome you writing that up as an issue.

For my part, I wouldn't like to see graphs at the top of pages.

As JJ says, you can see the graph clearly by clicking on the link that says 'vector' (perhaps that needs to be more obvious in some way?)

Ideally you wouldn't "go down several pages" but click on the link to Type Graph (Perhaps this needs to be more obvious in some way?)

I think the language pages are more beginner orientated and once you're banging around in types, you're in something more of a reference section and there needs to be some expectation of understanding what you're looking at and why (I think that it would be really useful to have a document perhaps explaining what you're looking at though!)

I'm not going to close this issue myself, otherwise it's just a tennis match, but if either @AlexDaniel or @ToddAndMargo want to, that would be good. It's definitely not a change that should be made in isolation.

@ToddAndMargo
Copy link
Author

ToddAndMargo commented Sep 18, 2018 via email

@ToddAndMargo
Copy link
Author

ToddAndMargo commented Sep 18, 2018 via email

@JJ
Copy link
Contributor

JJ commented Sep 21, 2018

@ToddAndMargo as participant in this issue, you should have received it. In the same email, there is a link in the bottom of the page which will direct you to all this conversation.

@ToddAndMargo
Copy link
Author

Closed: superseded by #2315

@AlexDaniel
Copy link
Member

Closed: superseded by #2315

But that's the same ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants