Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreadable type graphs #246

Closed
AlexDaniel opened this issue Dec 15, 2015 · 8 comments
Closed

Unreadable type graphs #246

AlexDaniel opened this issue Dec 15, 2015 · 8 comments

Comments

@AlexDaniel
Copy link
Member

See example here: http://doc.perl6.org/type/Metamodel::MethodContainer

That's how it is rendered for me:
Screenshot

And that's how provided PNG version looks like:
Auto generated PNG image

Zooming does not help. In fact, it seems like the svg is inlined, so I can't open it separately and zoom it there.
@AlexDaniel AlexDaniel mentioned this issue Jun 17, 2016
Closed
@AlexDaniel
Copy link
Member Author

I think that if we provide .svg links then this problem is not an issue. See #283

@AlexDaniel
Copy link
Member Author

I take my words back. This has to be fixed anyway, stand-alone images are just as unreadable even if zoomed: https://docs.perl6.org/images/type-graph-Metamodel%3A%3AMethodContainer.svg

@coke coke added site and removed build labels Jan 9, 2017
@AlexDaniel AlexDaniel self-assigned this Sep 2, 2017
@AlexDaniel AlexDaniel added build and removed site labels Sep 2, 2017
@AlexDaniel
Copy link
Member Author

AlexDaniel commented Sep 2, 2017 •
edited

OK, this is tough. Here's my progress so far.

  • To inspect generated dot input: Keep .dot files #1505
  • -Gaspect=1 does not work and prints Warning: the aspect attribute has been disabled due to implementation flaws - attribute ignored.
  • unflatten tool (normally installed with graphviz) does almost nothing, fiddling with its options didn't help. Note that this is a tool designed specifically for this problem.
  • ratio="compress" is not the right option for this problem (i.e. does not work)
  • using anything else than dot for large graphs may work (e.g. neato), but requires some custom options. Investigating now.

@AlexDaniel
Copy link
Member Author

Discussion and some pretty graphs: https://irclog.perlgeek.de/perl6/2017-09-02#i_15107475

@AlexDaniel
Copy link
Member Author

Unassigning myself because I'm getting burned on this issue. I hope my findings will help someone.

@AlexDaniel AlexDaniel removed their assignment Sep 2, 2017
@AlexDaniel
Copy link
Member Author

FWIW another interesting (possibly easier) graph issue: #72

@AlexDaniel
Copy link
Member Author

Actually, I think we need a rewrite of the code that does graph generation. See also 82966bc

@JJ
Copy link
Contributor

JJ commented Jan 26, 2018

Shouldn't that go to a separate issue?

JJ added a commit that referenced this issue Mar 23, 2018
@JJ
Changing dot to neato
facc0a6 
And also avoiding overlap. Ideally, it should help with #246. If it's
OK with everyone, close it.
@JJ JJ closed this as completed in 833d607 Mar 23, 2018
JJ added a commit that referenced this issue Mar 23, 2018
@JJ
Adds X::Comp to neato-ized files
27f3a15 
Check [IRC
log](discussion](https://irclog.perlgeek.de/perl6/2018-03-23#i_15958129))
for discussion. Also related to #246 (although it's closed).

Kudos and 👍 to @AlexDaniel for help.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JJ @coke @AlexDaniel