New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xt/examples-compilation.t is too memory-hungry and there are issues if we change EVAL to anything else #2764
Comments
|
That might make it even slower... Although there are known issues with this
like this one rakudo/rakudo#2324 (which was
solved, for no reason), this is not really intended to be run over all
examples, but only over the ones that have been modified. Other than that,
it's slow enough as it is, making it run one by one would be terribly
slow...
|
|
The problem is that tests might be written when there were only a few examples. Now there are some files that have hundreds of them. And examples are extracted, added to an array, and then tested... |
|
Opening it back again because of #2782. It might have something to do with this, since it happens only if the whole set is run. |
|
Cool, thanks! |
|
I'm sad to see this go. We spent a lot of effort to speed up the runtime of tests, and I would have liked to see a ticket get opened in rakudo to track the memory issue. There are, btw, many ways to run the the tests against just a subset of files, which avoids the cost of running the file against the whole suite of docs. (util/update-and-test, the TEST_FILES env var) |
|
@coke It's not gone for any meaning of the word. It's just working in a different way. Why do you feel it's gone? |
|
Ah, OK, the speed up is gone. We're trading memory for speed. It's not a big deal as long as you don't run the whole length of tests. |
|
(I just clicked on the wrong button, so let's say do close it again if it's not an issue) |
Thanks to @ugexe and @taboege for hints on how to make this. I've checked memory, and it's actually taking quite a bit of memory, but not as much as EVAL and it's actually faster than that. It's also producing a false positive with `class Metamodel::ParametricRoleHOW` which I don't know how to fix. Refs #2764 but leaves it open until * Memory usage has actually been addressed, and * We manage to fix that false positive
|
As @taboege pointed out, it's a flapper in the sense that it does not seem to error if we run that on the single file, it fails consistently if it's done on a group of files. |
The problem
Running the full xt/examples-compilation.t test brings my laptop to its knees: the memory used just keeps growing, so that I have to run it twice with half the tests each. They are over 5000 tests currently, but loading all those into memory is not the problem. The memory usage keeps rising to critical levels while those tests are executed.
Suggestions
Look for memory leaks. It might also be worthwhile to do one subtest per file and avoid loading all the tests into memory at the beginning.
The text was updated successfully, but these errors were encountered: