Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xt/aspell.t doc/Language/unicode_entry.pod6 #2869

Closed
coke opened this issue Jun 24, 2019 · 8 comments
Closed

xt/aspell.t doc/Language/unicode_entry.pod6 #2869

coke opened this issue Jun 24, 2019 · 8 comments
Assignees
Labels
xt Regarding current or new xt/ tests or the utils/

Comments

@coke
Copy link
Collaborator

coke commented Jun 24, 2019

The problem

$ xt/aspell.t doc/Language/unicode_entry.pod6

Fails after b4534db. Looks like commands that need to be added to the dictionary file.

@coke coke added the xt Regarding current or new xt/ tests or the utils/ label Jun 24, 2019
@JJ
Copy link
Contributor

JJ commented Jun 24, 2019

You mean the rxvt configuration commands?

@coke
Copy link
Collaborator Author

coke commented Jun 24, 2019

I didn't read the file or scope the words, just saw the failing test.

@JJ
Copy link
Contributor

JJ commented Jun 24, 2019 via email

@coke
Copy link
Collaborator Author

coke commented Jun 24, 2019

IMO yes, because there's a lot of items in code that are words, like comments, variable names, etc.

Even if they're not words, having the config "words" whitelisted means there's less chance of someone typo-ing them in other sections of the document.

@JJ
Copy link
Contributor

JJ commented Jun 24, 2019 via email

@coke
Copy link
Collaborator Author

coke commented Jun 24, 2019

I'm not sure rewriting the test to avoid code helps, given the large amount of code we do want tested. (Including use of official Perl 6 class names in code, e.g.). I don't think that the overhead on keeping the spelling test passing is that great, even in this particular case.

The only reason I posted this as a ticket was so that the original author could verify the spelling of the comands/params before we codified it.

@Kaiepi
Copy link
Collaborator

Kaiepi commented Jun 24, 2019

Looks like I missed a couple of colons in the XTerm config, but other than that there are no typos. My bad

Edit: URxvt.letterspace should also be URxvt.letterSpace

@coke coke self-assigned this Jun 27, 2019
@coke coke closed this as completed in f2522e2 Jun 27, 2019
@coke
Copy link
Collaborator Author

coke commented Jun 27, 2019

Looks like @Kaiepi fixed his own typo note above in 7688624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xt Regarding current or new xt/ tests or the utils/
Projects
None yet
Development

No branches or pull requests

3 participants