Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Dynamic variables” table is broken #754

Closed
AlexDaniel opened this issue Jul 24, 2016 · 9 comments
Closed

“Dynamic variables” table is broken #754

AlexDaniel opened this issue Jul 24, 2016 · 9 comments
Labels
docs Documentation issue (primary issue type)

Comments

@AlexDaniel
Copy link
Member

See https://docs.perl6.org/language/variables#Dynamic_variables

Ping @molecules

The problem occurs because of this:

    ------------------+--------------------------------------------
    $*SCHEDULER       | A L<ThreadPoolScheduler> object representing the current default
                      | scheduler.
                      |
                      | Note on usage: For the current Rakudo, by default this imposes a
                      | maximum of 16 threads on the methods C<.hyper> and C<.race>. To change
                      | the maximum number of threads, either set the environment variable
                      | RAKUDO_MAX_THREADS before running perl6 or create a scoped copy
                      | with the default changed before using C<.hyper> or C<.race>:
                      |
                      | my $*SCHEDULER = ThreadPoolScheduler.new( max_threads => 64 );
                      |
                      | This behavior is not tested in the spec tests and is subject to change.
    ------------------+--------------------------------------------

If you change it to this, then it works, but of course it does not look as nice:

    ------------------+--------------------------------------------
    $*SCHEDULER       | A L<ThreadPoolScheduler> object representing the current default
                      | scheduler.
                      | Note on usage: For the current Rakudo, by default this imposes a
                      | maximum of 16 threads on the methods C<.hyper> and C<.race>. To change
                      | the maximum number of threads, either set the environment variable
                      | RAKUDO_MAX_THREADS before running perl6 or create a scoped copy
                      | with the default changed before using C<.hyper> or C<.race>:
                      | my $*SCHEDULER = ThreadPoolScheduler.new( max_threads => 64 );
                      | This behavior is not tested in the spec tests and is subject to change.
    ------------------+--------------------------------------------

Is there any way to have paragraphs inside a table cell?

@AlexDaniel AlexDaniel added the docs Documentation issue (primary issue type) label Jul 24, 2016
@ShimmerFairy
Copy link
Contributor

While the parsing is definitely broken, note that table cells are meant to act like implicit =para blocks. So even when Pod parsing is fixed, multiple paragraphs would by definition not happen. Basically, whatever happens when you try typing multiple visual paragraphs inside a =begin para ... =end para block is what should happen in that table cell.

@tbrowder
Copy link
Member

At least it's lookong a bit better after my last tweak.

On Sunday, July 24, 2016, Faye notifications@github.com wrote:

While the parsing is definitely broken, note that table cells are meant to
act like implicit =para blocks. So even when Pod parsing is fixed, multiple
paragraphs would by definition not happen. Basically, whatever happens when
you try typing multiple visual paragraphs inside a =begin para ... =end
para block is what should happen in that table cell.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#754 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA_a1LANodTybG4PVlj_oAgynBixPM6Rks5qY-f0gaJpZM4JTrr4
.

@AlexDaniel
Copy link
Member Author

Except that now things like C<.race> are not rendered :(

@tbrowder
Copy link
Member

On Monday, July 25, 2016, Aleks-Daniel Jakimenko-Aleksejev <
notifications@github.com> wrote:

Except that now things like C<.race> are not rendered :(

Hm, I assume they were before. I think part of the problem is Pod::To::HTML
(and maybe htmlify.p6).

Shall I revert?

@tbrowder
Copy link
Member

On Monday, July 25, 2016, Tom Browder tom.browder@gmail.com wrote:

On Monday, July 25, 2016, Aleks-Daniel Jakimenko-Aleksejev <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Except that now things like C<.race> are not rendered :(

Hm, I assume they were before. I think part of the problem is
Pod::To::HTML (and maybe htmlify.p6).

Actually, I don't think any pod formatting codes have ever been recognized
in existing tables up til now.

@AlexDaniel
Copy link
Member Author

Shall I revert?

No, it's better than it was.

Still :( though.

@molecules
Copy link
Contributor

Is this better? #758

@tbrowder
Copy link
Member

On Mon, Jul 25, 2016 at 11:53 AM, Christopher Bottoms <
notifications@github.com> wrote:

Is this better? #758 #758

​Excellent, Christopher! And good practice for most tables--footnotes for
those interested in the details.

@AlexDaniel
Copy link
Member Author

OK, after #758 it is not broken anymore, so we can close this issue. … however, I'd love to see some changes to pod itself so that there's at least some way to have that kind of stuff in table cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issue (primary issue type)
Projects
None yet
Development

No branches or pull requests

4 participants