Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github/Atom highlighter for <15 minutes builds and better highlighting #1061

Merged
merged 19 commits into from Dec 21, 2016

Conversation

samcv
Copy link
Collaborator

@samcv samcv commented Dec 19, 2016

To use, run make init-highlights

then run make html-highlights

~15 minute build with my old x220 laptop!!!

P.S. you will need node to use this.
P.P.S. node may spit out some error messages at the end of installing, but everything is probably fine. Just ignore it.

If in doubt that it installed properly, run ./highlights/highlight-filename-from-stdin.coffee then type ./htmlify.p6 and then it should print out a bunch of html.

P.P.P.S. Make sure to clear your cache. If the code blocks are there but don't see anything highlighted, it probably has the old stylesheet cached.

@samcv
Copy link
Collaborator Author

samcv commented Dec 19, 2016

If somebody can check this out and let me know what you think ++

If we already have checked out the two repositories,
cd into them and git pull
console.log can do formatting of javascript data structures
Hopefully will be faster printing that way.

Not sure if making it async will make it faster, the same,
or slowing though.
Also remove an unneeded repo from the Makefile.
`highlights` is already in our node package file,
so it automatically downloads.
Also is renamed to be accurate about which highlighter it is
designed for.
This will allow us to use multiple threads by waiting for the results
from the correct file to be returned, and not just using the result
returned most recently.
@zoffixznet zoffixznet merged commit 12a65aa into master Dec 21, 2016
zoffixznet added a commit that referenced this pull request Dec 21, 2016
@zoffixznet zoffixznet deleted the highlights branch December 23, 2016 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants