New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github/Atom highlighter for <15 minutes builds and better highlighting #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If somebody can check this out and let me know what you think ++ |
If we already have checked out the two repositories, cd into them and git pull
console.log can do formatting of javascript data structures Hopefully will be faster printing that way. Not sure if making it async will make it faster, the same, or slowing though.
Also remove an unneeded repo from the Makefile. `highlights` is already in our node package file, so it automatically downloads.
Also is renamed to be accurate about which highlighter it is designed for.
This will allow us to use multiple threads by waiting for the results from the correct file to be returned, and not just using the result returned most recently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use, run
make init-highlightsthen run
make html-highlights~15 minute build with my old x220 laptop!!!
P.S. you will need node to use this.
P.P.S. node may spit out some error messages at the end of installing, but everything is probably fine. Just ignore it.
If in doubt that it installed properly, run
./highlights/highlight-filename-from-stdin.coffeethen type./htmlify.p6and then it should print out a bunch of html.P.P.P.S. Make sure to clear your cache. If the code blocks are there but don't see anything highlighted, it probably has the old stylesheet cached.