edits to exceptions pod #1172
Merged
edits to exceptions pod #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJ
reviewed
Jan 31, 2017
Altai-man
requested changes
Jan 31, 2017
|
|
||
| die "oops, something went wrong"; | ||
| #!> oops, something went wrong in block <unit> at my-script.p6:1 | ||
|
|
There was a problem hiding this comment.
Do we need an empty line in such cases?
There was a problem hiding this comment.
It scanned better for me with a breakline, here and other places.
| #-> OBAI | ||
|
|
||
| # -> OHAI | ||
| # -> OBAI |
There was a problem hiding this comment.
We are currently trying to establish a single comment line style, so this changes will be edited soon anyway.
There was a problem hiding this comment.
@JJ I'll fix that.
Altai-man
approved these changes
Feb 2, 2017
|
Does you built it on localhost? If examples with added new-lines are rendered fine, I'm fine with merging this, though I'm not sure about description text simplifications. It'd be better for someone more confident in English than me to check. |
tbrowder
approved these changes
Feb 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.