Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Telemetry and Telemetry::Period, lizmat++ #1660

Merged
merged 10 commits into from Nov 6, 2017
Merged

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Nov 5, 2017

These pod6 files cause build failure, maybe we can rewrite it in correct format.

@AlexDaniel
Copy link
Member

Can we also add a note saying that this is a Rakudo feature that is available starting with 2017.11 release?


=head1 Other methods

=head2 method gist / method Str
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it doesn't build because of this line?

Also note these warnings:

The subkinds of routine T in Telemetry cannot be determined. Are you sure that routine is actually defined in Telemetry's file?
The subkinds of routine snap in Telemetry cannot be determined. Are you sure that routine is actually defined in Telemetry's file?
The subkinds of routine snapper in Telemetry cannot be determined. Are you sure that routine is actually defined in Telemetry's file?
The subkinds of routine periods in Telemetry cannot be determined. Are you sure that routine is actually defined in Telemetry's file?
The subkinds of routine report in Telemetry cannot be determined. Are you sure that routine is actually defined in Telemetry's file?
  12/267: doc/Type/Telemetry/Period.pod6           => type/Telemetry::Period

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warnings occur because there are no definitions.

https://github.com/perl6/doc/blob/b3bf11df35203bf91cefe67f61338161818fc6f0/htmlify.p6#L612-L621

Maybe @lizmat knows where the definitions(Signatures) of these routines is.

@tisonkun
Copy link
Member Author

tisonkun commented Nov 5, 2017

@AlexDaniel is it a rakudo only feature?

@AlexDaniel
Copy link
Member

@W4anD0eR96 Until we have tests for it in roast it is fair to assume that new potential implementations will not implement it. Another similar case is dd.

@lizmat
Copy link
Collaborator

lizmat commented Nov 5, 2017

Yes, no tests in roast, just like dd. I would not consider it a Perl 6 feature at this time.

@lizmat
Copy link
Collaborator

lizmat commented Nov 5, 2017

eh, where did doc/Type/Telemetry.pod6 go ??? It's not in the branch ?

@tisonkun
Copy link
Member Author

tisonkun commented Nov 5, 2017

@lizmat , it's in this branch, both of them cause build failure. try to figure it out now.

@lizmat
Copy link
Collaborator

lizmat commented Nov 5, 2017

odd, in my local checkout it's definitely not there if I checkout the branch

@tisonkun
Copy link
Member Author

tisonkun commented Nov 5, 2017

it's in branch patch-01

@lizmat
Copy link
Collaborator

lizmat commented Nov 5, 2017

Ok, I'll leave you to it then :-)

@tisonkun tisonkun changed the title Document Telemetry and Telemetry::Period, lizmat++ [WIP] Document Telemetry and Telemetry::Period, lizmat++ Nov 5, 2017
@tisonkun tisonkun changed the title [WIP] Document Telemetry and Telemetry::Period, lizmat++ Document Telemetry and Telemetry::Period, lizmat++ Nov 5, 2017
@tisonkun
Copy link
Member Author

tisonkun commented Nov 5, 2017

Locally build ok, will merge it once travis-ci pass

@tisonkun tisonkun merged commit 42d87cf into master Nov 6, 2017
@tisonkun tisonkun deleted the patch-01 branch November 6, 2017 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants