Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vim settings bits from a number of documents. #172

Closed
wants to merge 1 commit into from

Conversation

djgoku
Copy link

@djgoku djgoku commented Oct 21, 2015

I found the issue by seeing *.pod files being broken in github. Remove all instances I could find.

@moritz
Copy link
Collaborator

moritz commented Oct 21, 2015

The modelines are there for a reason; rejecting.

(Also pod being broken on github is a symptom of github not rendering Perl 6 pod, not of the modeliness)

@moritz moritz closed this Oct 21, 2015
@djgoku
Copy link
Author

djgoku commented Oct 21, 2015

Can you point me to a document the reasoning/explanation?

If they are supposed to be there, is there a reason it isn't present on every file?

Jonathan Otsuka

On Oct 20, 2015, at 11:39 PM, Moritz Lenz notifications@github.com wrote:

The modelines are there for a reason; rejecting.

(Also pod being broken on github is a symptom of github not rendering Perl 6 pod, not of the modeliness)


Reply to this email directly or view it on GitHub.

@moritz
Copy link
Collaborator

moritz commented Oct 21, 2015

It's not documented. It's simply handy that every contributor (at least those using vim) uses the same editor settings.

And it's not in every file because we haven't bothered to automate it.

@paultcochrane
Copy link
Contributor

Would it be generally worthwhile to automate it? If so, I could add a check for the appropriate modelines and add them where necessary.

@zoffixznet
Copy link
Contributor

Broken .pods are unrelated to vim settings (See #167)

@djgoku
Copy link
Author

djgoku commented Oct 21, 2015

Could we not add a recommended vimrc file with all the settings and point people to it?

@FROGGS
Copy link
Contributor

FROGGS commented Oct 21, 2015

How do you do that? And how nice will that play with ppl jumping between projects?

For example we added the vimlines to the core setting files to not let hard tabs sneak into our codebase. Even when I'm not using vim, I understand that we want to keep them.

@djgoku
Copy link
Author

djgoku commented Oct 21, 2015

I don't use vim so I can't relate. I use the defaults for vi, sublime text and atom.

@moritz
Copy link
Collaborator

moritz commented Oct 21, 2015

What's the big issue here? Why can't we just keep the status quo? What's the problem?

@jonathanstowe
Copy link
Contributor

There isn't one. In any other text editor the modeline is just a comment, if something is attempting to parse the file and getting confused by a comment then that thing is broken not the document.

@zoffixznet
Copy link
Contributor

Reading the discussion, I think this was left un answered:

moritz: And it's not in every file because we haven't bothered to automate it.

paultcochrane: Would it be generally worthwhile to automate it? If so, I could add a check for the appropriate modelines and add them where necessary.

@jonathanstowe
Copy link
Contributor

So I'd say 👍 to @paultcochrane's suggestion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants