New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vim settings bits from a number of documents. #172
Conversation
|
The modelines are there for a reason; rejecting. (Also pod being broken on github is a symptom of github not rendering Perl 6 pod, not of the modeliness) |
|
Can you point me to a document the reasoning/explanation? If they are supposed to be there, is there a reason it isn't present on every file? Jonathan Otsuka
|
|
It's not documented. It's simply handy that every contributor (at least those using vim) uses the same editor settings. And it's not in every file because we haven't bothered to automate it. |
|
Would it be generally worthwhile to automate it? If so, I could add a check for the appropriate modelines and add them where necessary. |
|
Broken |
|
Could we not add a recommended vimrc file with all the settings and point people to it? |
|
How do you do that? And how nice will that play with ppl jumping between projects? For example we added the vimlines to the core setting files to not let hard tabs sneak into our codebase. Even when I'm not using vim, I understand that we want to keep them. |
|
I don't use vim so I can't relate. I use the defaults for vi, sublime text and atom. |
|
What's the big issue here? Why can't we just keep the status quo? What's the problem? |
|
There isn't one. In any other text editor the modeline is just a comment, if something is attempting to parse the file and getting confused by a comment then that thing is broken not the document. |
|
Reading the discussion, I think this was left un answered:
|
|
So I'd say 👍 to @paultcochrane's suggestion :) |
I found the issue by seeing
*.podfiles being broken in github. Remove all instances I could find.