Fix missing nodejs dependency in the Dockerfile. #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details:
- It appears that the nodejs package no longer exists for the base image
used by the Dockerfile, and since it's already using the `n` script to
install the latest stable version of nodejs, I simply use `n` to
install nodejs in the first place instead.
- Also fixed a small code formatting issue in packages.pod6.
- Corrected the instructions on running the built docker image in CONTRIBUTING.md.
JJ
approved these changes
Jun 8, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the nodejs package no longer exists for the base image
used by the Dockerfile, and since it's already using the
nscript toinstall the latest stable version of nodejs, I simply use
ntoinstall nodejs in the first place instead.
Also fixed a small code formatting issue in packages.pod6.
Corrected the instructions on running the built docker image in CONTRIBUTING.md.
Initially, I was only trying to fix the formatting issue in packages.pod6, but couldn't get
Mojolicious working to be able to preview my changes, so I ended up building a docker
image from the Dockerfile.