Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pod-tables scroll horizontally on smaller views #2258

Merged
merged 1 commit into from Aug 13, 2018

Conversation

MorayJ
Copy link
Contributor

@MorayJ MorayJ commented Aug 13, 2018

If a table is too wide for a page a horizontal scroll bar will be added to the bottom.

If the page is focused, the right key will scroll right and left to come back.

I'm presuming this will work on mobile with finger dragging, but no testing set up for that at the moment.

The problem

Squished table cells on mobile #650

Table columns that are outside the viewport are not viewable. Problem on mobile. This occurs in the bug report and is also in the 'Routines' page, directly linkable from the front page of the site making the bug quite prominent.

Solution provided

Add css via sass generator following advice from someone's question on stackoverflow (https://stackoverflow.com/questions/5533636/add-horizontal-scrollbar-to-html-table) on best way for creating scrollable table.

Requested reviews as not sure if other solutions in the offing and as a site wide change with potential repercussions, would like it viewed.

If a table is too wide for a page a horizontal scroll bar will be added to the bottom.

If the page is focused, the right key will scroll right and left to come back.

I'm presuming this will work on mobile with finger dragging, but no testing set up for that at the moment.
@AlexDaniel
Copy link
Member

FWIW currently github does not link your commits to your github account. You can simply add the email address that you have in git user.email to the list on https://github.com/settings/emails and it will pick it up. Also, feel free to add yourself to https://github.com/perl6/doc/blob/master/CREDITS so that your preferred name is used in rakudo announcements.

@zoffixznet zoffixznet removed their request for review August 13, 2018 15:03
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I haven't checked it, though, but it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants