Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Should be a fix for rakudo/issues/#2466 #2432

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Xliff
Copy link
Collaborator

@Xliff Xliff commented Nov 2, 2018

The problem

See rakudo/rakudo/#2466.

This addresses the issue with the example for IO::Handle.Supply.

-->

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know what to make of this. You mean that that is the way it's actually written?

@Xliff
Copy link
Collaborator Author

Xliff commented Nov 2, 2018

Yes. The code is fine, it's the output that is incorrect. This fixes that problem.

@JJ JJ merged commit 920cc6f into Raku:master Nov 2, 2018
@jnthn
Copy link
Contributor

jnthn commented Nov 2, 2018

However, there is a problem still, because it says or C<65536> characters in non-binary mode, which is not true: the size argument (I've grumbled about the name on the Rakudo issue) is actually the I/O buffer size, which is always measured in bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants