Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about coercion overhead to Any.pick (addresses #2537). #2538

Closed
wants to merge 1 commit into from
Closed

Add a note about coercion overhead to Any.pick (addresses #2537). #2538

wants to merge 1 commit into from

Conversation

cfa
Copy link
Contributor

@cfa cfa commented Jan 6, 2019

Draft wording for #2537.

(Please only merge this if Any is deemed an appropriate place for this warning.)

@cfa cfa requested a review from AlexDaniel January 6, 2019 20:25
JJ
JJ reviewed Jan 7, 2019
View reviewed changes
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment went more along the way of putting this in the Traps page. If you decide to put it here, maybe it's better to use N<>

@cfa
Copy link
Contributor Author

cfa commented Jan 7, 2019

Sure, happy to pop this in a footnote if that's better/clearer.

@cfa cfa requested a review from lizmat January 7, 2019 16:58
@cfa cfa closed this Jan 8, 2019
@cfa cfa deleted the any-pick branch January 8, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJ JJ JJ left review comments

@AlexDaniel AlexDaniel Awaiting requested review from AlexDaniel

@lizmat lizmat Awaiting requested review from lizmat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cfa @JJ