Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document trap on set subroutines on Associative #2563

Merged
merged 1 commit into from Jan 13, 2019
Merged

Conversation

Kaiepi
Copy link
Collaborator

@Kaiepi Kaiepi commented Jan 13, 2019

Fixes rakudo/rakudo#2604

The problem

Map/Bag/BagHash/Hash (cont) <string> returns False if the value of the key is falsey.

Solution provided

Document the trap.

@Kaiepi Kaiepi changed the title Document trap on (cont) subroutine on Map/Hash Document trap on (cont) subroutine on Map/Bag/Hash Jan 13, 2019
@lizmat
Copy link
Collaborator

lizmat commented Jan 13, 2019

Cool!

Perhaps also mention this applies to all related ops (cont), ∋, ∌ and (elem), ∈, ∉ ?

@Kaiepi Kaiepi force-pushed the traps branch 2 times, most recently from 029fa6a to 9dc756a Compare January 13, 2019 17:46
@Kaiepi
Copy link
Collaborator Author

Kaiepi commented Jan 13, 2019

Updated

@Kaiepi Kaiepi force-pushed the traps branch 2 times, most recently from 49a6d9f to 5d05b92 Compare January 13, 2019 17:48
@Kaiepi Kaiepi changed the title Document trap on (cont) subroutine on Map/Bag/Hash Document trap on set subroutines on Map/Bag/BagHash/Hash Jan 13, 2019
@Kaiepi Kaiepi changed the title Document trap on set subroutines on Map/Bag/BagHash/Hash Document trap on set subroutines on Associative Jan 13, 2019
@lizmat lizmat merged commit ca3067e into Raku:master Jan 13, 2019
@lizmat
Copy link
Collaborator

lizmat commented Jan 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants