Some redactional changes and corrections #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizmat
reviewed
Jul 27, 2019
doc/Language/regexes.pod6
Outdated
| other characters must either be escaped with a backslash (for example, C<\:> | ||
| to match a colon), or be within quotes: | ||
| Alphanumeric characters, including the underscore C<_> which is considered | ||
| alphabetic, are matched literally. All other characters must either be escaped |
There was a problem hiding this comment.
This feels wrong, because it might give the impression that dd "_" ~~ /<:alpha>/ would give a Match. I would remove the "which is considered alphabetic" part.
There was a problem hiding this comment.
I understand what you are saying. At the same time, "_".match(/ <alpha> /) does yield a Match, which is why the current text confuses me. But I see now that <alpha> is actually defined as "Alphabetic characters including _", so there is consistency. I'll revert the proposed change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to clarify, prettify, and correct some matters in the regexes-section, most notably the incorrect reference to $?NL in the discussion of the backslashed character class \n.