Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a very small error in Baggy #3027

Closed
wants to merge 1 commit into from

Conversation

zostay
Copy link
Contributor

@zostay zostay commented Sep 18, 2019

The problem

The example output shows (b b b), but it ought to be (a b b) or some permutation of that.

Solution provided

I changed the example output to (a b b). This is still slightly misleading as that's only one of 3 possible outcomes, but it's better than (b b b) which is none of the possible outcomes.

@Altai-man
Copy link
Member

What rakudo version do you use?

➜  ~ perl6 --version
This is Rakudo version 2019.07 built on MoarVM version 2019.07
implementing Perl 6.d.
➜  ~ perl6 -e 'my $n = ("a" => 0, "b" => 1, "b" => 2).BagHash; say $n.kxxv;'
(b b b)
➜  ~ 

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelia attached to the perl6 IRC channel returns the same thing, b b b. I think that's the latest HEAD.

@JJ
Copy link
Contributor

JJ commented Sep 20, 2019

Also, a has weight 0, so it makes sense it does not show up.

@coke
Copy link
Collaborator

coke commented Feb 18, 2020

Based on comments from September (and another test in my sandbox), rejecting patch, as current "b b b" seems correct.

@coke coke closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants