Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License::Software #452

Open
AlexDaniel opened this issue Feb 8, 2019 · 5 comments
Open

License::Software #452

AlexDaniel opened this issue Feb 8, 2019 · 5 comments
Assignees
Labels
works for me Does not seem to be any problem

Comments

@AlexDaniel
Copy link
Member

Module License::Software cannot be installed (AlwaysFail), perhaps it has some failing tests.

  • Tickets are opened/closed in this repo automatically (though not immediately).
  • If you can install the module without any problems, add works for me label, leave a comment saying that it works for you and mention any details that you feel are important.
  • If it needs a native library, put native dependency label, describe what you did to install it and ensure that same instructions are present in the README file of the module (otherwise submit a pull request). Also try to update this wiki page.
  • If the module is broken, try to fix it and send a PR. Add PR sent label.
  • If there is a problem in one of the dependencies, add failing dependency label and write a comment explaining the situation. Feel free to work on the corresponding ticket for the failing dependency.
  • It is a good idea to assign yourself to this ticket if you're working on it (to make sure two or more people are not working on the same ticket at the same time).
  • Once you are done, search for a next ticket.

If you can't self-assign yourself or attach a label, please let us know on #perl6 channel on freenode or just leave a comment here. We will try to give you privileges as fast as possible.

Output:

===> Searching for: License::Software
===> Found: License::Software:ver<0.2.0>:auth<kalkin> [via Zef::Repository::Ecosystems<p6c>]
===> Fetching [OK]: License::Software:ver<0.2.0>:auth<kalkin> to /home/alex/Blin/data/zef-data/tmp/1549583282.18598.4157/License-Software.git
===> Extraction [OK]: License::Software to /home/alex/Blin/data/zef-data/store/License-Software.git
===> Testing: License::Software:ver<0.2.0>:auth<kalkin>
    # github source https://github.com/kalkin/License-Software needs to end in .git
t/00-meta.t ....... ok
Failed to get the directory contents of '/home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/data/zef/lib': Failed to open dir: No such file or directory
  in sub find at /home/alex/Blin/installed/File::Find_0.1/sources/338438A16791DC5A3816B1052C78248FFDAFFEAB (File::Find) line 35
  in block  at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 122
  in sub find-modules at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 120
  in sub plugins at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 155
  in any  at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/.precomp/1EDB85121726B40D5B30BA34561E237620A6B9EE/7E/7E21BE01333F1B417B38FBB0C211D48A2DBAD54E line 1
  in sub get-all at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 162
  in block <unit> at t/01-basic.t line 5

t/01-basic.t ...... 
Dubious, test returned 1 (wstat 256, 0x100)
No subtests run 
Failed to get the directory contents of '/home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/data/zef/lib': Failed to open dir: No such file or directory
  in sub find at /home/alex/Blin/installed/File::Find_0.1/sources/338438A16791DC5A3816B1052C78248FFDAFFEAB (File::Find) line 35
  in block  at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 122
  in sub find-modules at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 120
  in sub plugins at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 155
  in any  at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/.precomp/1EDB85121726B40D5B30BA34561E237620A6B9EE/7E/7E21BE01333F1B417B38FBB0C211D48A2DBAD54E line 1
  in sub get-all at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 162
  in sub license at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 171
  in block <unit> at t/10-gplv3.t line 8

t/10-gplv3.t ...... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 10/10 subtests 
Failed to get the directory contents of '/home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/data/zef/lib': Failed to open dir: No such file or directory
  in sub find at /home/alex/Blin/installed/File::Find_0.1/sources/338438A16791DC5A3816B1052C78248FFDAFFEAB (File::Find) line 35
  in block  at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 122
  in sub find-modules at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 120
  in sub plugins at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 155
  in any  at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/.precomp/1EDB85121726B40D5B30BA34561E237620A6B9EE/7E/7E21BE01333F1B417B38FBB0C211D48A2DBAD54E line 1
  in sub get-all at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 162
  in sub license at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 171
  in block <unit> at t/11-Apache2.t line 9

t/11-Apache2.t .... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 13/13 subtests 
Failed to get the directory contents of '/home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/data/zef/lib': Failed to open dir: No such file or directory
  in sub find at /home/alex/Blin/installed/File::Find_0.1/sources/338438A16791DC5A3816B1052C78248FFDAFFEAB (File::Find) line 35
  in block  at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 122
  in sub find-modules at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 120
  in sub plugins at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 155
  in any  at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/.precomp/1EDB85121726B40D5B30BA34561E237620A6B9EE/7E/7E21BE01333F1B417B38FBB0C211D48A2DBAD54E line 1
  in sub get-all at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 162
  in sub license at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 171
  in block <unit> at t/12-LGPLv3.t line 8

t/12-LGPLv3.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 8/8 subtests 
Failed to get the directory contents of '/home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/data/zef/lib': Failed to open dir: No such file or directory
  in sub find at /home/alex/Blin/installed/File::Find_0.1/sources/338438A16791DC5A3816B1052C78248FFDAFFEAB (File::Find) line 35
  in block  at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 122
  in sub find-modules at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 120
  in sub plugins at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 155
  in any  at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/.precomp/1EDB85121726B40D5B30BA34561E237620A6B9EE/7E/7E21BE01333F1B417B38FBB0C211D48A2DBAD54E line 1
  in sub get-all at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 162
  in sub license at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 171
  in block <unit> at t/13-AGPLv3.t line 7

t/13-AGPLv3.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 11/11 subtests 
Failed to get the directory contents of '/home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/data/zef/lib': Failed to open dir: No such file or directory
  in sub find at /home/alex/Blin/installed/File::Find_0.1/sources/338438A16791DC5A3816B1052C78248FFDAFFEAB (File::Find) line 35
  in block  at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 122
  in sub find-modules at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 120
  in sub plugins at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 155
  in any  at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/.precomp/1EDB85121726B40D5B30BA34561E237620A6B9EE/7E/7E21BE01333F1B417B38FBB0C211D48A2DBAD54E line 1
  in sub get-all at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 162
  in sub license at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 171
  in block <unit> at t/14-Artistic2.t line 7

t/14-Artistic2.t .. 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 8/8 subtests 
Failed to get the directory contents of '/home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/data/zef/lib': Failed to open dir: No such file or directory
  in sub find at /home/alex/Blin/installed/File::Find_0.1/sources/338438A16791DC5A3816B1052C78248FFDAFFEAB (File::Find) line 35
  in block  at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 122
  in sub find-modules at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 120
  in sub plugins at /home/alex/Blin/installed/Pluggable_0.3/sources/388FC30FD6DA4E1B7F6FAD8C8D04A2761C8C9A11 (Pluggable) line 155
  in any  at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/.precomp/1EDB85121726B40D5B30BA34561E237620A6B9EE/7E/7E21BE01333F1B417B38FBB0C211D48A2DBAD54E line 1
  in sub get-all at /home/alex/Blin/data/zef-data/store/License-Software.git/0b115fe34743b7bec78c3ced63e5fc1ec16afa19/lib/License/Software.pm6 (License::Software) line 162
  in block <unit> at t/20-spdx.t line 6

t/20-spdx.t ....... 
Dubious, test returned 1 (wstat 256, 0x100)
No subtests run 

Test Summary Report
-------------------
t/01-basic.t    (Wstat: 256 Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/10-gplv3.t    (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10 tests but ran 0.
t/11-Apache2.t  (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 13 tests but ran 0.
t/12-LGPLv3.t   (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 8 tests but ran 0.
t/13-AGPLv3.t   (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 11 tests but ran 0.
t/14-Artistic2.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 8 tests but ran 0.
t/20-spdx.t     (Wstat: 256 Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
Files=8, Tests=1, 29 wallclock secs ( 0.04 usr  0.01 sys + 22.64 cusr  1.57 csys = 24.26 CPU)
Result: FAIL
===> Testing [FAIL]: License::Software:ver<0.2.0>:auth<kalkin>
Failed to get passing tests, but continuing with --force-test
===> Installing: License::Software:ver<0.2.0>:auth<kalkin>
===> Install [OK] for License::Software:ver<0.2.0>:auth<kalkin>

Ping @kalkin

@JJ JJ self-assigned this Feb 8, 2019
@JJ
Copy link
Collaborator

JJ commented Feb 8, 2019

This is the same kind of error that wasn't really an error in other I worked with. I'll check anyway.

@JJ JJ added the works for me Does not seem to be any problem label Feb 8, 2019
@JJ
Copy link
Collaborator

JJ commented Feb 9, 2019

Fails because #502

@kalkin
Copy link

kalkin commented Feb 16, 2019

I have noticed this issue. As far as i understand my module is not broken, it's the testing?

@jonathanstowe
Copy link

jonathanstowe commented Feb 16, 2019

Testing locally I see a different failure:

===> Testing: License::Software:ver<0.2.0>:auth<kalkin>
Testing with plugin: Zef::Service::TAP+{<anon|1>}
    # github source https://github.com/kalkin/License-Software needs to end in .git
t/00-meta.t ....... ok
t/01-basic.t ...... ok
t/10-gplv3.t ...... ok
Can not find license alias 'apache'
  in sub license at /home/jonathan/devel/perl6/3rdparty-modules/License-Software/lib/License/Software.pm6 (License::Software) line 172
Type check failed for return value; expected License::Software::Abstract but got Int (0)
  in sub license at /home/jonathan/devel/perl6/3rdparty-modules/License-Software/lib/License/Software.pm6 (License::Software) line 172
  in block <unit> at t/11-Apache2.t line 19

# Looks like you planned 13 tests, but ran 9
t/11-Apache2.t .... Dubious, test returned 255
All 13 subtests passed 
t/12-LGPLv3.t ..... ok
t/13-AGPLv3.t ..... ok
t/14-Artistic2.t .. ok
Failed
  in block <unit> at t/20-spdx.t line 6

Actually thrown at:
  in code  at t/20-spdx.t line 9
  in block <unit> at t/20-spdx.t line 6

t/20-spdx.t ....... Dubious, test returned 1
No subtests run
All tests successful.

Test Summary Report
-------------------
t/11-Apache2.t  (Wstat: 65280 Tests: 9 Failed: 0)
Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 13 tests but ran 9.
t/20-spdx.t  (Wstat: 256 Tests: 0 Failed: 0)
Non-zero exit status: 1
  Parse errors: No plan found in TAP output
Files=8, Tests=48,  16 wallclock secs
Result: FAILED
===> Testing [FAIL]: License::Software:ver<0.2.0>:auth<kalkin>
Aborting due to test failure: License::Software:ver<0.2.0>:auth<kalkin> (use --force-test to override)
[jonathan@coriolanus License-Software]$ 

Which is consistent however it is run.

The weird bit is that when run one on its own I get an additional error:

X::NoSuchSymbol(SETTING::src/core/Exception.pm6 62 throw)

But I can't find where that is coming from.

Having instrumented get-all I can see that it is getting all the licenses and all things be equal should find the right one, so I suspect there is some not quite right in the set operation in license.

Incidently the license should return a License::Software::Abstract in the case where it doesn't find the license so

diff --git a/lib/License/Software.pm6 b/lib/License/Software.pm6
index c6b2ab4..1dd9e46 100644
--- a/lib/License/Software.pm6
+++ b/lib/License/Software.pm6
@@ -170,12 +170,14 @@ sub license(Str:D $alias) is export returns License::Software::Abstract
 {
     for get-all() -> $license { return $license if $alias.uc ∈ $license.aliases».uc }
     warn "Can not find license alias '$alias'";
+    License::Software::Abstract;
 }
 
 sub license-from-url(Str:D $url ) is export returns License::Software::Abstract
 {
     for get-all() -> $license { return $license if $url ~~ $license.url }
     warn "Can not find license with url '$url'";
+    License::Software::Abstract;
 }
 =COPYRIGHT Copyright © 2016 Bahtiar `kalkin-` Gadimov <bahtiar@gadimov.de>
 

Would fix.

@kalkin
Copy link

kalkin commented Feb 16, 2019

@jonathanstowe Can't reproduce locally. How exactly did you run tests? zef test passes for me:

> zef test .
===> Testing: License::Software:ver<0.3.0>:auth<kalkin>
    # github source https://github.com/kalkin/License-Software needs to end in .git
===> Testing [OK] for License::Software:ver<0.3.0>:auth<kalkin>

EDIT: Also passes ddt test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
works for me Does not seem to be any problem
Projects
None yet
Development

No branches or pull requests

4 participants