Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Math::Primesieve to ecosystem #333

Merged
merged 1 commit into from May 2, 2017
Merged

Conversation

CurtTilmes
Copy link
Contributor

See https://github.com/CurtTilmes/perl6-primesieve

Thank you for submitting a module to the Perl 6 Ecosystem!

If adding a new module please review the following check boxes and check the appropriate boxes by going to the preview tab and checking them interactively or alternatively replacing the space in the checkboxes with an X. Your work is appreciated and every module helps make the Perl 6 Ecosystem a bigger and better place ♥

  • [ X ] I agree to the usage of the META file as listed here.

  • [ X ] I have a license field listed in my META file that is one of https://spdx.org/licenses

    • My license is not one of those found on spdx.org but I do have a license field.
      In this case make sure you have a license URL listed under support. See this example.
    • I don't have a license field. Yes, I understand this is not recommended.

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI has detected an error in the META6.json file. Can you please check it out? I can't figure it out by myself.

@the-eater
Copy link
Contributor

the-eater commented May 2, 2017 via email

@JJ
Copy link
Contributor

JJ commented May 2, 2017

That's one of the errors, line 1202 far as I see it. I was talking about the one in line 1232.

not ok 1 - Checking correctness of https://raw.githubusercontent.com/CurtTilmes/perl6-primesieve/master/META6.json

Did you check that the JSON was correct?

The one in 1202 might be also an issue. Can you please check it?

@the-eater
Copy link
Contributor

the-eater commented May 2, 2017 via email

@JJ
Copy link
Contributor

JJ commented May 2, 2017

OK, I see your point, but you are right about the fact that there is no good way to specify external dependencies so the test still fails and will probably fail if someone tries to install this via zef. I would be more comfortable with someone else accepting this PR. Meanwhile, you can go to the IRC channel to see if there's a good workaround this for the time being.

@moritz moritz merged commit 2af4592 into Raku:master May 2, 2017
@moritz
Copy link
Contributor

moritz commented May 2, 2017

Thanks @CurtTilmes, and welcome to the club!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants